Skip to content

Conversation

@AdrianoDee
Copy link
Contributor

PR description:

The 2026 version of #46445.

This PR proposes the addition of 2026 wfs to the matrix. For the moment, they are a copy of what we run currently for 2025 with the idea that once 2026 parameters (conditions, HLT menu) come, we will need to fill the dummy ones (keeping them in sync with each other). For the moment:

  • @relval2026 is pointing toGRun (@cms-sw/hlt-l2, let me know if you prefer something different there);
  • auto:phase1_2026_* symbolic GTs are copies of 2025 ones (@cms-sw/alca-l2 let me know what you think about this, I'll updated them following your suggestion);

The era is Era_2026 that, for now, is just a copy of Era_2025 (the same for FastSim, just fyi @cms-sw/simulation-l2). TTbar 2026 noPU/PU wfs are added to the limited matrix to be tested with PRs. The standard PU input for 2026 wfs is the same as 2025 for now. I took the chance to update also the GPU workflows to 2026 (@cms-sw/heterogeneous-l2) so that we avoid running them with the fake menu when 2025 wfs will be switching to that (as happened last year).

PR validation:

New wfs run.

@AdrianoDee
Copy link
Contributor Author

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2025

cms-bot internal usage

@AdrianoDee
Copy link
Contributor Author

please test
(the new tests are in the limited matrix now)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49419/46876

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/Eras (operations)
  • Configuration/HLT (hlt)
  • Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @Martin-Grunewald, @antoniovagnerini, @arunhep, @atpathak, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen, @miquork, @mmusich, @perrotta can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @mmusich, @rsreds, @slomeo, @tocheng, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49419/46877

@AdrianoDee
Copy link
Contributor Author

please abort

@perrotta
Copy link
Contributor

+alca

'relval2022' : 'Fake2',
'relval2023' : 'Fake2',
'relval2024' : 'Fake2',
'relval2025' : '2025v13',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eventually, now that we have coverage I guess we can demote this to fake (in another PR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd wait to do that after pre3 is out just to use 2025 for one last round of validations.

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2025

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2025

Out of curiosity @cms-sw/dqm-l2 is it expected that in this PR the DQM bin-by-bin comparison is empty: https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_16_0_X_2025-11-21-1100+fd870d/71938/dqm-histo-comparison-summary.html ?

@gabrielmscampos
Copy link
Member

gabrielmscampos commented Nov 24, 2025

Out of curiosity @cms-sw/dqm-l2 is it expected that in this PR the DQM bin-by-bin comparison is empty: cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_16_0_X_2025-11-21-1100+fd870d/71938/dqm-histo-comparison-summary.html ?

I'd say that is unusual. I was taking a look at signed and merged PRs from last week that target 16_0_X and the cmsdt pages are still available and most of them also are displaying empty DQM bin-by-bin comparison.

On this specific PR, I cannot find the /RelVal_wf25202_0_pr/CMSSW_16_0_X-PRcmssw_49419-XXXXXX/DQMIO dataset in the Development GUI. Maybe the ROOT file was not uploaded at the end of the tests? Can we check Jenkins's logs to check this?

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2025

shall we try to test again?

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 24, 2025

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_16_0_X_2025-11-21-1100+fd870d/71938/dqmBinByBinLog.log shows some root/python errors [a] . Could this be the reason the dqm bin-by-bin comparison were not properly done ? Could it be due to ROOT 6.36 update?

[a]

PR file successfully opened
Traceback (most recent call last):
  File "/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49419/49598/CMSSW_16_0_X_2025-11-21-1100/bin/el8_amd64_gcc13/compareHistograms.py", line 345, in <module>
    create_dif(args.base_file, args.pr_file, args.pr_number, args.test_number, cmssw_version, args.num_processes, args.output_dir)
  File "/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49419/49598/CMSSW_16_0_X_2025-11-21-1100/bin/el8_amd64_gcc13/compareHistograms.py", line 80, in create_dif
    compare(shared_paths, pr_flat_dict, base_flat_dict, paths_to_save_in_pr, paths_to_save_in_base)
  File "/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49419/49598/CMSSW_16_0_X_2025-11-21-1100/bin/el8_amd64_gcc13/compareHistograms.py", line 182, in compare
    pr_array = np.array(pr_item)
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc13/lcg/root/6.36.05-302290958d85790e78b48654c2f216ba/lib/ROOT/_pythonization/_uhi.py", line 367, in _getitem
    uhi_index = _compute_common_index(self, index)
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc13/lcg/root/6.36.05-302290958d85790e78b48654c2f216ba/lib/ROOT/_pythonization/_uhi.py", line 223, in _compute_common_index
    return [_compute_uhi_index(self, idx, axis, include_flow_bins) for axis, idx in enumerate(index)]
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc13/lcg/root/6.36.05-302290958d85790e78b48654c2f216ba/lib/ROOT/_pythonization/_uhi.py", line 223, in <listcomp>
    return [_compute_uhi_index(self, idx, axis, include_flow_bins) for axis, idx in enumerate(index)]
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc13/lcg/root/6.36.05-302290958d85790e78b48654c2f216ba/lib/ROOT/_pythonization/_uhi.py", line 192, in _compute_uhi_index
    return _process_index_for_axis(self, index, axis)
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02916/el8_amd64_gcc13/lcg/root/6.36.05-302290958d85790e78b48654c2f216ba/lib/ROOT/_pythonization/_uhi.py", line 180, in _process_index_for_axis
    raise IndexError(f"Histogram index {index - 1} out of range for axis {axis}. Valid range: (0,{nbins})")
IndexError: Histogram index 30 out of range for axis 0. Valid range: (0,30)

@gabrielmscampos
Copy link
Member

cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_16_0_X_2025-11-21-1100+fd870d/71938/dqmBinByBinLog.log shows some root/python errors [a] . Could this be the reason the dqm bin-by-bin comparison were not properly done ? Could it be due to ROOT 6.36 update?

That is right, at the end of the log we can see that there were no files to be uploaded as well.

shall we try to test again?

I don't think testing again will solve the issue.

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2025

Could this be the reason the dqm bin-by-bin comparison were not properly done ? Could it be due to ROOT 6.36 update?

so just to be clear, the issue is not coming specifically from this PR, but it's also present in all other recent PRs?

@gabrielmscampos
Copy link
Member

@smuzaffar
Copy link
Contributor

this might be related to ROOT 6.36 change root-project/root@ff65e3b which is in 16.0.X IBs .

@smuzaffar
Copy link
Contributor

@smuzaffar
Copy link
Contributor

I am opening a new issue to track dqm bin-by-bin failures

@smuzaffar
Copy link
Contributor

#49452

@mmusich
Copy link
Contributor

mmusich commented Nov 24, 2025

I am opening a new issue to track dqm bin-by-bin failures

thanks!

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b610721 into cms-sw:master Nov 24, 2025
25 checks passed
@AdrianoDee AdrianoDee deleted the relval_2026_wfs branch November 24, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants