adding options for reco step using new rawSecond input #49481

saswatinandan · 2025-11-26T11:30:53Z

This PR is to add option in cmsDriver for reco step so that new rawSecond dataformat (49036) can be used.

For example:

cmsDriver.py step3 --conditions 151X_dataRun3_Prompt_v1 -s RAW2DIGI,L1Reco,RECO --datatier RECO --eventcontent RECO --data --process reRECO --scenario pp --era Run3_pp_on_PbPb_approxSiStripClusters_2025 --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run3 --hltProcess reHLT -n 100 --no_exec --repacked --rawSecond

cmsbuild · 2025-11-26T11:31:15Z

cms-bot internal usage

cmsbuild · 2025-11-26T11:32:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49481/46963

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): Move dqmoffline_step from EndPath to Path #49385

cmsbuild · 2025-11-26T11:32:48Z

A new Pull Request was created by @saswatinandan for master.

It involves the following packages:

Configuration/Applications (operations)
Configuration/DataProcessing (operations)

@cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2025-11-27T07:42:48Z

This PR is to add option in cmsDriver for reco step so that new rawSecond dataformat (#49036) can be used.

would it not be better to package it into an era (e.g. Run3_pp_on_PbPb_rawSecond_2025) and corresponding reconstruction scenario?

cmsbuild · 2025-11-27T09:33:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49481/46996

Found files with invalid states:
- Configuration/DataProcessing/python/rawSecond.py:
  - Added: 3098e22
  - Deleted: 6a49a75
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): Move dqmoffline_step from EndPath to Path #49385
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): update on strip approximate cluster #47367, Rpc digi dev v9 #47447
- File RecoLocalTracker/SiStripClusterizer/python/SiStripClusterizer_RealData_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2025-11-27T09:34:00Z

Pull request #49481 was updated. @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

saswatinandan · 2025-11-27T09:36:48Z

New command to run the reco step as follow:
cmsDriver.py step3 --conditions 151X_dataRun3_Prompt_v1 -s RAW2DIGI,L1Reco,RECO --datatier RECO --eventcontent RECO --data --process reRECO --scenario pp --era Run3_pp_on_PbPb_approxSiStripClusters_2025_rawSecond --customise Configuration/DataProcessing/RecoTLR.customisePostEra_Run3 --hltProcess reHLT -n 100 --no_exec --repacked

mmusich · 2025-11-27T09:42:28Z

Configuration/Applications/python/ConfigBuilder.py

            self.pythonCfgCode +="from Configuration.Applications.ConfigBuilder import MassReplaceInputTag\n"
            self.pythonCfgCode +="MassReplaceInputTag(process, new=\"rawDataMapperByLabel\", old=\"rawDataCollector\")\n"
            MassReplaceInputTag(self.process, new="rawDataMapperByLabel", old="rawDataCollector")
-


this line is now unnecessary.

mmusich · 2025-11-27T10:23:50Z

Configuration/EventContent/python/EventContent_cff.py

+from Configuration.ProcessModifiers.rawSecond_cff import rawSecond
+rawSecond.toModify(RAWEventContent,
+                              outputCommands = RAWEventContent.outputCommands+[
+                                  'keep *_hltSiStripClusters2ApproxClustersv1_*_*',


Looking forwarrd, do you want to use the rawSecond modifier always in conjunction of approxSiStripClusters? In that case I think you might want to make sure you drop the other version of the approximate clusters. In that case also adding DetIds_hltSiStripRawToDigi_*_* is redundant.

mmusich · 2025-11-27T10:23:57Z

Configuration/EventContent/python/EventContent_cff.py

                              ])
-
+rawSecond.toModify(FEVTDEBUGEventContent,
+                              outputCommands = FEVTDEBUGEventContent.outputCommands+[


mmusich · 2025-11-27T10:24:02Z

Configuration/EventContent/python/EventContent_cff.py

                              ])
+rawSecond.toModify(FEVTDEBUGHLTEventContent,
+                              outputCommands = FEVTDEBUGHLTEventContent.outputCommands+[
+                                  'keep *_hltSiStripClusters2ApproxClustersv1_*_*',


cmsbuild · 2025-11-27T12:01:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49481/46999

Found files with invalid states:
- Configuration/DataProcessing/python/rawSecond.py:
  - Added: 3098e22
  - Deleted: 6a49a75
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Applications/python/ConfigBuilder.py modified in PR(s): Move dqmoffline_step from EndPath to Path #49385
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): update on strip approximate cluster #47367, Rpc digi dev v9 #47447
- File RecoLocalTracker/SiStripClusterizer/python/SiStripClusterizer_RealData_cfi.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2025-11-27T12:01:55Z

Pull request #49481 was updated. @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

mmusich · 2025-11-27T12:26:20Z

@cmsbuild, please test

cmsbuild · 2025-11-27T14:14:44Z

+1

Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7db3bc/49717/summary.html
COMMIT: aed6da1
CMSSW: CMSSW_16_0_X_2025-11-27-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49481/49717/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 4 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4269233
DQMHistoTests: Total failures: 64
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4269149
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

jfernan2 · 2025-11-27T14:33:00Z

+1

cmsbuild · 2025-11-27T14:33:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-11-27T17:43:11Z

+1

adding options for reco step using new rawSecond input

3098e22

cmsbuild added this to the CMSSW_16_0_X milestone Nov 26, 2025

cmsbuild added operations-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 26, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 26, 2025

implementing suggestion as received in PR

6a49a75

cmsbuild added reconstruction-pending code-checks-pending trk and removed code-checks-approved labels Nov 27, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 27, 2025

mmusich reviewed Nov 27, 2025

View reviewed changes

remving previous approx cluster collection

f3bbc99

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 27, 2025

adding back empty line

aed6da1

cmsbuild removed the code-checks-pending label Nov 27, 2025

cmsbuild added the code-checks-approved label Nov 27, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 27, 2025

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Nov 27, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Nov 27, 2025

cmsbuild added orp-approved and removed orp-pending labels Nov 27, 2025

cmsbuild merged commit 505e43f into cms-sw:master Nov 27, 2025
10 checks passed

adding options for reco step using new rawSecond input #49481

adding options for reco step using new rawSecond input #49481

Uh oh!

Conversation

saswatinandan commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

mmusich commented Nov 27, 2025

Uh oh!

cmsbuild commented Nov 27, 2025

Uh oh!

cmsbuild commented Nov 27, 2025

Uh oh!

saswatinandan commented Nov 27, 2025

Uh oh!

mmusich Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Nov 27, 2025

Uh oh!

cmsbuild commented Nov 27, 2025

Uh oh!

mmusich commented Nov 27, 2025

Uh oh!

cmsbuild commented Nov 27, 2025

Comparison Summary

Uh oh!

jfernan2 commented Nov 27, 2025

Uh oh!

cmsbuild commented Nov 27, 2025

Uh oh!

mandrenguyen commented Nov 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Nov 26, 2025 •

edited

Loading