Phase 2 - Add new tracker DQM histograms showing OT cluster position in 2S modules & ladders #49482

ljuckett · 2025-11-26T11:51:46Z

PR description:

Adds 2 types of histogram to SiTrackerPhase2 OT Clusters:
PositionOfClusters_2S shows all strips that constitute clusters in 2S modules. Each module number has its own histogram named as PositionOfClusters_2S_. This creates 24 histograms in barrel layers 4-6 and the following amount in the endcaps:

TEDD 1
Ring 11: 52
Ring 12: 60
Ring 13: 64
Ring 14: 72
Ring 15: 76

TEDD 2
Ring 8: 52
Ring 9: 56
Ring 10: 64
Ring 11: 68
Ring 12: 76

Positive y bins are on the top sensor of the module, with negative y bins on the bottom. 1 or 2 indicates the half-sensor. It is possible to view the whole 2S module on one plot.

PositionOfClusters_2SLadder shows the total number of clusters in each module in a ladder. Similarly to the module view it produces different number of histograms per layer:
Layer 4: 48 ladders
Layer 5: 60 ladders
Layer 6: 76 ladders

This histogram shows modules before the collision point with a negative value and after the collision point with a positive value. Technically, it displays 2 ladders per plot as the - and + ladders are not the same structure.

These histograms are proposed to show data primarily from the cosmic rack.

PR was validated by running the Phase-2 tracker DQM and checking the ROOT result

cmsbuild · 2025-11-26T11:52:08Z

cms-bot internal usage

cmsbuild · 2025-11-26T11:53:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49482/46964

cmsbuild · 2025-11-26T11:53:56Z

A new Pull Request was created by @ljuckett for master.

It involves the following packages:

DQM/SiTrackerPhase2 (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@arossi83, @mmusich, @richa2710, @sroychow this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

DQM/SiTrackerPhase2/plugins/Phase2OTMonitorCluster.cc

cmsbuild · 2025-12-18T13:00:09Z

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

…dder numbers

cmsbuild · 2025-12-18T21:08:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49482/47231

cmsbuild · 2025-12-18T21:08:45Z

Pull request #49482 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

nothingface0 · 2025-12-19T08:54:44Z

@cmsbuild please test

Thanks @ljuckett !

cmsbuild · 2025-12-19T11:17:11Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e49ec/50360/summary.html
COMMIT: e93f1ab
CMSSW: CMSSW_16_0_X_2025-12-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49482/50360/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 9 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4280393
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4280361
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 378814.19999999995 KiB( 52 files compared)
DQMHistoSizes: changed ( 34434.0,... ): 37884.420 KiB HLT/TrackerPhase2OTCluster
DQMHistoSizes: changed ( 34434.0,... ): 17861.057 KiB TrackerPhase2OTCluster/EndCap_Side1
DQMHistoSizes: changed ( 34434.0,... ): 17861.057 KiB TrackerPhase2OTCluster/EndCap_Side2
DQMHistoSizes: changed ( 34434.0,... ): 2156.307 KiB TrackerPhase2OTCluster/Barrel
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

mmusich · 2025-12-19T11:37:15Z

DQM/SiTrackerPhase2/plugins/Phase2OTMonitorCluster.cc

+      //Book the right number of histograms per layer
+      unsigned int nModules = 0;
+      unsigned int nLadders = 0;
+
+      TrackerGeometry::DetIdContainer theDetIds = tkGeom_->detIds();
+      for (auto detid : theDetIds) {
+        if (tkGeom_->getDetectorType(detid) == TrackerGeometry::ModuleType::Ph2SS &&
+            tTopo_->getOTLayerNumber(det_id) == tTopo_->getOTLayerNumber(detid)) {
+          if ((tTopo_->getOTLayerNumber(detid) < 100) ||
+              (tTopo_->getOTLayerNumber(detid) > 100 && tTopo_->tidRing(det_id) == tTopo_->tidRing(detid))) {
+            nModules = (tTopo_->module(detid) > nModules) ? tTopo_->module(detid) : nModules;
+            nLadders = ((tTopo_->getOTLayerNumber(detid) < 100) && (tTopo_->tobRod(detid) > nLadders))
+                           ? tTopo_->tobRod(detid)
+                           : nLadders;
+          }
+        }
+      }


I still find the current construct hard to digest (and also relies on this hardcoded 100 that come from here

cmssw/DataFormats/TrackerCommon/src/TrackerTopology.cc

Lines 545 to 546 in b0efeef

} else if (id.subdetId() == SiStripSubdetector::TID) {

layer = 100 * tidSide(id) + tidWheel(id);

just to distinguish barrel / endcaps.
Would something lilke

Suggested change

//Book the right number of histograms per layer

unsigned int nModules = 0;

unsigned int nLadders = 0;

TrackerGeometry::DetIdContainer theDetIds = tkGeom_->detIds();

for (auto detid : theDetIds) {

if (tkGeom_->getDetectorType(detid) == TrackerGeometry::ModuleType::Ph2SS &&

tTopo_->getOTLayerNumber(det_id) == tTopo_->getOTLayerNumber(detid)) {

if ((tTopo_->getOTLayerNumber(detid) < 100) ||

(tTopo_->getOTLayerNumber(detid) > 100 && tTopo_->tidRing(det_id) == tTopo_->tidRing(detid))) {

nModules = (tTopo_->module(detid) > nModules) ? tTopo_->module(detid) : nModules;

nLadders = ((tTopo_->getOTLayerNumber(detid) < 100) && (tTopo_->tobRod(detid) > nLadders))

? tTopo_->tobRod(detid)

: nLadders;

}

}

}

unsigned int nModules = 0;

unsigned int nLadders = 0;

const auto refLayer = tTopo_->getOTLayerNumber(det_id);

const bool refIsBarrel = (det_id.subdetId() == SiStripSubdetector::TOB);

const int refRing = refIsBarrel ? -1 : tTopo_->tidRing(det_id);

for (const auto detid : tkGeom_->detIds()) {

if (tkGeom_->getDetectorType(detid) != TrackerGeometry::ModuleType::Ph2SS)

continue;

if (tTopo_->getOTLayerNumber(detid) != refLayer)

continue;

const bool isBarrel = (detid.subdetId() == SiStripSubdetector::TOB);

// Barrel: accept all

// Endcap: require same ring

if (!isBarrel && tTopo_->tidRing(detid) != refRing)

continue;

nModules = std::max(nModules, static_cast<unsigned int>(tTopo_->module(detid)));

if (isBarrel) {

nLadders = std::max(nLadders, static_cast<unsigned int>(tTopo_->tobRod(detid)));

}

}

work?

Good shout. I've implemented the changes

cmsbuild · 2025-12-19T15:20:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49482/47246

cmsbuild · 2025-12-19T15:20:41Z

Pull request #49482 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

nothingface0 · 2025-12-19T15:47:01Z

@cmsbuild please test

cmsbuild · 2025-12-19T17:31:40Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e49ec/50374/summary.html
COMMIT: 735e8c8
CMSSW: CMSSW_16_1_X_2025-12-19-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49482/50374/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
250202.181 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 15 lines to the logs
Reco comparison results: 7 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4280393
DQMHistoTests: Total failures: 84
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4280289
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 378814.19999999995 KiB( 52 files compared)
DQMHistoSizes: changed ( 34434.0,... ): 37884.420 KiB HLT/TrackerPhase2OTCluster
DQMHistoSizes: changed ( 34434.0,... ): 17861.057 KiB TrackerPhase2OTCluster/EndCap_Side1
DQMHistoSizes: changed ( 34434.0,... ): 17861.057 KiB TrackerPhase2OTCluster/EndCap_Side2
DQMHistoSizes: changed ( 34434.0,... ): 2156.307 KiB TrackerPhase2OTCluster/Barrel
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

ljuckett added 2 commits November 25, 2025 15:03

Add cluster position histograms for 2S modules

a52259d

Code format

b99c525

cmsbuild added this to the CMSSW_16_0_X milestone Nov 26, 2025

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Nov 26, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 26, 2025

mmusich reviewed Nov 26, 2025

View reviewed changes

DQM/SiTrackerPhase2/plugins/Phase2OTMonitorCluster.cc Outdated Show resolved Hide resolved

ljuckett marked this pull request as draft December 11, 2025 11:52

cmsbuild modified the milestones: CMSSW_16_0_X, CMSSW_16_1_X Dec 18, 2025

Remove hardcoded values and add iterator to calculate total module/la…

e93f1ab

…dder numbers

cmsbuild added code-checks-pending and removed code-checks-approved labels Dec 18, 2025

ljuckett marked this pull request as ready for review December 18, 2025 21:06

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 18, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 19, 2025

cmsbuild added tests-approved and removed tests-started labels Dec 19, 2025

mmusich reviewed Dec 19, 2025

View reviewed changes

Improve readability of module-counter

735e8c8

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Dec 19, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 19, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 19, 2025

cmsbuild added tests-approved and removed tests-started labels Dec 19, 2025

	} else if (id.subdetId() == SiStripSubdetector::TID) {
	layer = 100 * tidSide(id) + tidWheel(id);

-      //Book the right number of histograms per layer
-      unsigned int nModules = 0;
-      unsigned int nLadders = 0;
-      TrackerGeometry::DetIdContainer theDetIds = tkGeom_->detIds();
-      for (auto detid : theDetIds) {
-        if (tkGeom_->getDetectorType(detid) == TrackerGeometry::ModuleType::Ph2SS &&
-            tTopo_->getOTLayerNumber(det_id) == tTopo_->getOTLayerNumber(detid)) {
-          if ((tTopo_->getOTLayerNumber(detid) < 100) ||
-              (tTopo_->getOTLayerNumber(detid) > 100 && tTopo_->tidRing(det_id) == tTopo_->tidRing(detid))) {
-            nModules = (tTopo_->module(detid) > nModules) ? tTopo_->module(detid) : nModules;
-            nLadders = ((tTopo_->getOTLayerNumber(detid) < 100) && (tTopo_->tobRod(detid) > nLadders))
-                           ? tTopo_->tobRod(detid)
-                           : nLadders;
-          }
-        }
-      }
+unsigned int nModules = 0;
+unsigned int nLadders = 0;
+const auto refLayer = tTopo_->getOTLayerNumber(det_id);
+const bool refIsBarrel = (det_id.subdetId() == SiStripSubdetector::TOB);
+const int refRing = refIsBarrel ? -1 : tTopo_->tidRing(det_id);
+for (const auto detid : tkGeom_->detIds()) {
+  if (tkGeom_->getDetectorType(detid) != TrackerGeometry::ModuleType::Ph2SS)
+    continue;
+  if (tTopo_->getOTLayerNumber(detid) != refLayer)
+    continue;
+  const bool isBarrel = (detid.subdetId() == SiStripSubdetector::TOB);
+  // Barrel: accept all
+  // Endcap: require same ring
+  if (!isBarrel && tTopo_->tidRing(detid) != refRing)
+    continue;
+  nModules = std::max(nModules, static_cast<unsigned int>(tTopo_->module(detid)));
+  if (isBarrel) {
+    nLadders = std::max(nLadders, static_cast<unsigned int>(tTopo_->tobRod(detid)));
+  }
+}

Phase 2 - Add new tracker DQM histograms showing OT cluster position in 2S modules & ladders #49482

Are you sure you want to change the base?

Phase 2 - Add new tracker DQM histograms showing OT cluster position in 2S modules & ladders #49482

Conversation

ljuckett commented Nov 26, 2025

PR description:

Uh oh!

cmsbuild commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

Uh oh!

cmsbuild commented Dec 18, 2025

Uh oh!

cmsbuild commented Dec 18, 2025

Uh oh!

cmsbuild commented Dec 18, 2025

Uh oh!

nothingface0 commented Dec 19, 2025

Uh oh!

cmsbuild commented Dec 19, 2025

Comparison Summary

Uh oh!

mmusich Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

ljuckett Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Dec 19, 2025

Uh oh!

cmsbuild commented Dec 19, 2025

Uh oh!

nothingface0 commented Dec 19, 2025

Uh oh!

cmsbuild commented Dec 19, 2025

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Nov 26, 2025 •

edited

Loading