Infrastructure for HCAL channel-dependent pulse shapes using database configurations #49556
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49556/47076
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49556/47077
|
|
A new Pull Request was created by @igv4321 for master. It involves the following packages:
@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
you can make yourself a PR to this repository https://github.com/cms-data/CondTools-Hcal and then the two PRs can be tested together. |
|
@igv4321 do the changes need to be propagated to the heterogeneous version of the code under |
It would be nice to propagate them, but HCAL DPG does not have an alpaka expert at the moment. But even if just for offline, this capability is very useful. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49556/47083
|
|
Pull request #49556 was updated. @Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @srimanob can you please check and sign again. |
|
+1 Size: This PR adds an extra 32KB to repository Comparison SummarySummary:
|
perrotta
left a comment
perrotta
left a comment
There was a problem hiding this comment.
Not yet a complete review of the code. However, these Clang Warnings reported in the test results must be fixed.
| if (inputIsArchive) { | ||
| std::ios_base::openmode mode; | ||
| const bool usingTxt = is_text_file(inputfile); | ||
| if (!usingTxt) |
There was a problem hiding this comment.
CondTools/Hcal/test/format_HcalInterpolatedPulseMap.cc
src/CondTools/Hcal/test/format_HcalInterpolatedPulseMap.cc:93:7: warning: variable 'mode' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
src/CondTools/Hcal/test/format_HcalInterpolatedPulseMap.cc:69:9: warning: variable 'mode' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
| // Are we using a text archive as output? | ||
| std::ios_base::openmode mode; | ||
| const bool usingTxt = is_text_file(outputfile); | ||
| if (!usingTxt) |
There was a problem hiding this comment.
CondTools/Hcal/test/format_HcalInterpolatedPulseMap.cc
src/CondTools/Hcal/test/format_HcalInterpolatedPulseMap.cc:93:7: warning: variable 'mode' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
src/CondTools/Hcal/test/format_HcalInterpolatedPulseMap.cc:69:9: warning: variable 'mode' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49556/47239
|
|
Pull request #49556 was updated. @Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @srimanob can you please check and sign again. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49556/47240
|
|
Pull request #49556 was updated. @Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @srimanob can you please check and sign again. |
|
please test with cms-data/CondTools-Hcal#2 |
|
+1 Size: This PR adds an extra 16KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummaryThere are some workflows for which there are errors in the baseline: The workflows 2024.0070001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
6 participants
PR description:
Adding infrastructure for modeling HCAL front-end pulse shapes channel-by-channel. This PR superseeds #45995
Naturally, db-based pulse shapes are not enabled yet (they are not in the CMS database), so no changes in validation expected at the moment.
PR validation:
The usual matrix tests were run. The facilities for reading/writing the database tables were privately tested. I need somebody with right permissions to take the file CondTools/Hcal/test/hcalpulsedelays.txt and copy it into a directory where it can be found by "edmFileInPath". Then I will be able to turn on the unit test for the database table of pulse height delays.