Skip to content

Conversation

@a-wesole
Copy link

PR description:

This PR is needed to for creating an official MC in CMSSW_13_0_23_HeavyIon. I am doing a physics analysis in PbPb of studying the DDbar delta_phi correlation. For my analysis I need an official MC of only events containing at least 2 D0->k,pi decays

  • in the PR I added a specific filter that only permits events with at least 2 decays of D0->k,pi
  • GeneratorInterface/GenFilters/plugins/GenD0PairToKPiFilter.cc
  • It does not depend on other PR or externals
  • As far as I could tell the existing CMSSW filters are not compatible with requiring pairs
  • To be clear, this filter (and PR) will be used when I request the official MC

PR validation:

I produced 3M+ events with this filter according to the GEN/SIM steps and wrote a python script that analyzes all the outputted events to ensure that all of them do, in fact, have at least 2 instances of D0->k,pi

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It is intended to backport to CMSSW_13_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 18, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49662/47211

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #49662 was updated.

@a-wesole a-wesole marked this pull request as ready for review December 18, 2025 00:31
@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_16_0_X, CMSSW_16_1_X Dec 18, 2025
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @a-wesole for master.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@cmsbuild, @lviliani, @mkirsano, @sensrcn, @theofil can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild modified the milestones: CMSSW_16_0_X, CMSSW_16_1_X Dec 18, 2025
@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5d02d/50340/summary.html
COMMIT: 6984f7c
CMSSW: CMSSW_16_0_X_2025-12-17-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49662/50340/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2024.0040001, 2024.0020001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially added 4 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 7617 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280393
  • DQMHistoTests: Total failures: 11464
  • DQMHistoTests: Total nulls: 49
  • DQMHistoTests: Total successes: 4268860
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -38.278999999999996 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 2024.0020001 ): 3.309 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2024.0020001 ): 0.082 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2024.0020001 ): 0.069 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2024.0020001 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0040001 ): -40.648 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2024.0040001 ): -1.008 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2024.0040001 ): -0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2024.0040001 ): 0.047 KiB JetMET/SUSYDQM
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 1 / 51 workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants