Skip to content

Add 2026 PbPb eras #49684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stahlleiton wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add 2026 PbPb eras #49684

stahlleiton wants to merge 1 commit into from

Conversation

@stahlleiton
Copy link
Contributor

@stahlleiton stahlleiton commented Dec 19, 2025

PR description:

This PR adds 2026 PbPb eras and their corresponding relvals.

@mandrenguyen

PR validation:

Tested with relvals 143.901,143.902,143.911,143.912,143.921,144.901,144.902,163,163.02,163.03,163.1,163.2,163.3,163.4,183,183.1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 16_0_X

@cmsbuild cmsbuild added this to the CMSSW_16_1_X milestone Dec 19, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49684/47249

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2025

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv)
  • Configuration/StandardSequences (operations)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen, @miquork can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @makortel, @mmasciov, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@stahlleiton stahlleiton mentioned this pull request Dec 20, 2025
Open
mmusich
mmusich reviewed Dec 21, 2025
View reviewed changes
Configuration/PyReleaseValidation/python/relval_steps.py Outdated
steps['RESIM']=merge([{'-s':'reGEN,reSIM','-n':10},steps['DIGI']])
#steps['RESIMDIGI']=merge([{'-s':'reGEN,reSIM,DIGI,L1,DIGI2RAW,HLT:@fake,RAW2DIGI,L1Reco','-n':10,'--restoreRNDSeeds':'','--process':'HLT'},steps['DIGI']])

steps['DIGIHI2026APPROXCLUSTERS']=merge([{'-s':'DIGI:pdigi_hi_nogen,L1,DIGI2RAW,HLT:@fake2'}, hiDefaults2026_approxClusters, {'--pileup':'HiMixNoPU'}, step2Upg2015Defaults])
Copy link
Contributor

@mmusich mmusich Dec 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this (and elsewhere) use a new autoHLT key provisionally pointing to Fake2 (why not HIon directly, btw?) to make this slightly more maintainable?

Copy link
Contributor Author

@stahlleiton stahlleiton Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. I replaced the HLT key to "relvalHI2026" and point the key to HIon in the latest commit

@stahlleiton stahlleiton force-pushed the Era_2026_PbPb_CMSSW_16_1_X branch from 7c4fad9 to 0c5a4c0 Compare December 21, 2025 15:16
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 21, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49684/47253

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 21, 2025

Pull request #49684 was updated. @AdrianoDee, @DickyChant, @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen, @miquork, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Dec 21, 2025

test parameters:

  • workflows = 143.901,143.902,143.911,143.912,143.921,144.901,144.902,163,163.02,163.03,163.1,163.2,163.3,163.4,183,183.1

@mmusich
Copy link
Contributor

mmusich commented Dec 21, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 21, 2025

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ffa40/50382/summary.html
COMMIT: 0c5a4c0
CMSSW: CMSSW_16_1_X_2025-12-21-0000/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49684/50382/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280553
  • DQMHistoTests: Total failures: 61
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4280472
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmusich mmusich mmusich left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-checks-approved hlt-pending operations-approved orp-pending pdmv-pending pending-signatures tests-approved

Projects

None yet

Milestone

CMSSW_16_1_X

Development

Successfully merging this pull request may close these issues.

3 participants

@stahlleiton @cmsbuild @mmusich