Remove obsolete CUDA-using modules from DQM/SiPixelHeterogeneous #49697

makortel · 2025-12-22T17:06:08Z

PR description:

This PR removes CUDA-depending modules from DQM/SiPixelHeterogeneous. The inclusion of these modules in runTheMatrix workflow configurations came up in failures following CUDADataFormats dictionary removal in #49656 (comment). Since all direct CUDA components are slated for removal (#45844), this PR suggests to remove them. These components seem to have been superseded by more generic ones in #45206.

Resolves cms-sw/framework-team#1742

PR validation:

Workflows 11634.5 and 34434.5 succeeded.

These modules seem to have been supersed by more generic ones: - SiPixelCompareVertexSoA -> SiPixelCompareVertices - SiPixel*CompareRecHitsSoA -> SiPixel*CompareRecHits - SiPixel*CompareTrackSoA -> SiPixel*CompareTracks - SiPixel*MonitorRecHitsSoA -> SiPixel*MonitorRecHitsSoAAlpaka - SiPixel*MonitorTrackSoA -> SiPixel*MonitorTrackSoAAlpaka - SiPixelMonitorVertexSoA -> SiPixelMonitorVertexSoAAlpaka

cmsbuild · 2025-12-22T17:06:36Z

cms-bot internal usage

makortel · 2025-12-22T17:07:32Z

FYI @cms-sw/heterogeneous-l2

cmsbuild · 2025-12-22T17:07:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49697/47255

There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/SiPixelHeterogeneous/plugins/BuildFile.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareRecHitsSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareTrackSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelCompareVertexSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorRecHitsSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorTrackSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/plugins/SiPixelMonitorVertexSoA.cc modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction #45853
- File DQM/SiPixelHeterogeneous/python/SiPixelHeterogenousDQM_FirstStep_cff.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

cmsbuild · 2025-12-22T17:07:54Z

A new Pull Request was created by @makortel for master.

It involves the following packages:

DQM/SiPixelHeterogeneous (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@fioriNTU, @idebruyn, @jandrea, @mmusich, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel · 2025-12-22T17:09:22Z

test parameters:

workflows = 136.8855,136.8885,11634.5,34434.5
enable = gpu

makortel · 2025-12-22T17:09:28Z

@cmsbuild, please test

makortel · 2025-12-22T17:10:37Z

DQM/SiPixelHeterogeneous/python/SiPixelHeterogenousDQM_FirstStep_cff.py


 # Run-3 sequence
-monitorpixelSoASource = cms.Sequence(siPixelPhase1MonitorRecHitsSoA * siPixelPhase1MonitorTrackSoA * siPixelMonitorVertexSoA)
+monitorpixelSoASource = cms.Sequence()


It is not clear to me if these empty sequences serve any purpose anymore other than being placeholders that are toReplaceWith() below with various modifiers.

makortel · 2025-12-22T17:11:08Z

DQM/SiPixelHeterogeneous/python/SiPixelHeterogenousDQM_FirstStep_cff.py

 monitorpixelSoACompareSource = cms.Sequence(siPixelPhase1MonitorRawDataACPU *
                                            siPixelPhase1MonitorRawDataAGPU *
-                                            siPixelPhase1MonitorRecHitsSoACPU *
-                                            siPixelPhase1MonitorRecHitsSoAGPU *
-                                            siPixelPhase1CompareRecHitsSoA *
-                                            siPixelPhase1MonitorTrackSoAGPU *
-                                            siPixelPhase1MonitorTrackSoACPU *
-                                            siPixelPhase1CompareTrackSoA *
-                                            siPixelMonitorVertexSoACPU *
-                                            siPixelMonitorVertexSoAGPU *
-                                            siPixelCompareVertexSoA *
                                            siPixelPhase1RawDataErrorComparator)


It is not clear to me if the remaining 3 modules in this Sequence would be useful, or if it would be better to remove them as well.

cmsbuild · 2025-12-22T19:11:07Z

-1

Failed Tests: RelVals-NVIDIA_T4
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-046ac5/50392/summary.html
COMMIT: d99a3f5
CMSSW: CMSSW_16_1_X_2025-12-22-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49697/50392/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals-NVIDIA_T4

ValueError: Undefined workflows: 29834.751, 29834.404, 29834.402, 29834.704, 29834.403

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.5 step 3
136.8855 step 3
136.8885 step 3
34434.5 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 99 lines to the logs
Reco comparison results: 12 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4280553
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4280518
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 239 log files, 204 edm output root files, 53 DQM output files
TriggerResults: no differences found

makortel · 2025-12-22T19:24:16Z

ValueError: Undefined workflows: 29834.751, 29834.404, 29834.402, 29834.704, 29834.403

I wonder what this means in practice

makortel · 2025-12-22T19:26:27Z

ValueError: Undefined workflows: 29834.751, 29834.404, 29834.402, 29834.704, 29834.403

I wonder what this means in practice

I opened an issue #49700

makortel mentioned this pull request Dec 22, 2025

Remove most dictionaries of CUDADataFormats #49656

Merged

cmsbuild added this to the CMSSW_16_1_X milestone Dec 22, 2025

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Dec 22, 2025

makortel mentioned this pull request Dec 22, 2025

Drop support for native CUDA code #45844

Open

52 tasks

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 22, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 22, 2025

makortel commented Dec 22, 2025

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Dec 22, 2025

makortel mentioned this pull request Dec 22, 2025

GPU PR tests failing with "Undefined workflows" #49700

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove obsolete CUDA-using modules from DQM/SiPixelHeterogeneous #49697

Remove obsolete CUDA-using modules from DQM/SiPixelHeterogeneous #49697

makortel commented Dec 22, 2025 •

edited

Loading

Uh oh!

cmsbuild commented Dec 22, 2025 •

edited

Loading

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

cmsbuild commented Dec 22, 2025

Uh oh!

cmsbuild commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

makortel Dec 22, 2025

Uh oh!

makortel Dec 22, 2025

Uh oh!

cmsbuild commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Remove obsolete CUDA-using modules from DQM/SiPixelHeterogeneous #49697

Are you sure you want to change the base?

Remove obsolete CUDA-using modules from DQM/SiPixelHeterogeneous #49697

Conversation

makortel commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

cmsbuild commented Dec 22, 2025

Uh oh!

cmsbuild commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

makortel Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

makortel Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Dec 22, 2025

Failed RelVals-NVIDIA_T4

Comparison Summary

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

makortel commented Dec 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

makortel commented Dec 22, 2025 •

edited

Loading

cmsbuild commented Dec 22, 2025 •

edited

Loading