Skip to content

Conversation

@missirol
Copy link
Contributor

@missirol missirol commented Jan 9, 2026

PR description:

This PR fixes the "Pt" inputs used in the inference of AXOL1TL models in the L1-uGT emulation.

  • Without this PR, these "pT" values are truncated to integers (which is unintended, as far as I understand).
  • With this PR, the data-emulator mismatches for L1T algorithms involving AXOL1TL (recently mentioned in #49056 (comment) are reduced by ~10x (see the validation section in #49754 (comment)).

This is a bugfix. It affects only the results of the L1-uGT emulation for AXOL1TL seeds.

PR validation:

None beyond the validation done for #49754.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

To be backported at least to CMSSW_16_0_X for 2026 data-taking purposes (e.g. L1-uGT online DQM). Might also be backported to earlier releases (down to CMSSW_14_0_X CMSSW_13_3_X) to fix the L1T decisions of AXOL1TL seeds in MC.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49753/47338

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2026

A new Pull Request was created by @missirol for master.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Jan 9, 2026

type bugfix

@quinnanm
Copy link
Contributor

quinnanm commented Jan 9, 2026

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f05ccc/50496/summary.html
COMMIT: ea1b2ed
CMSSW: CMSSW_16_1_X_2026-01-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49753/50496/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 7 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4167425
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4167297
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 1 / 51 workflows

@missirol
Copy link
Contributor Author

The outputs of the PR tests look okay.

  • The changes in "TriggerResults" are consistent with the content of this PR (only AXOL1TL-related triggers are affected).
  • The few discrepancies in DQM bin-by-bin comparisons are spurious and/or not related to this PR (e.g. #47071).

@missirol
Copy link
Contributor Author

To be backported at least to CMSSW_16_0_X for 2026 data-taking purposes (e.g. L1-uGT online DQM). Might also be backported to earlier releases (down to CMSSW_14_0_X CMSSW_13_3_X) to fix the L1T decisions of AXOL1TL seeds in MC.

Based on feedback from the L1T group, this simple fix has been backported to the older cycles affected by the bug in question, in case any of those cycles will be used for future MC campaigns (e.g. Run-3 "Legacy" MC). The quantitative impact of this fix is likely small, but somewhat unknown depending on phase-space selection and physics signal, so it was considered safer to backport the bugfix.

@quinnanm
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3d28b37 into cms-sw:master Jan 13, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants