-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Remove alpaka procModfier from workflows in which it is no longer useful #49755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove alpaka procModfier from workflows in which it is no longer useful #49755
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49755/47340
|
|
A new Pull Request was created by @VourMa for master. It involves the following packages:
@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @miquork can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
assign hlt
|
|
New categories assigned: hlt @Martin-Grunewald,@mmusich you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
Thanks for the work on this, but I don’t think we should proceed with these changes. By removing In my view, the For these reasons, I think removing |
|
Hi @mmusich, these are valid concerns that I thought a bit about. Let me reply inline and we can discuss further:
The
I agree. As I tried to explain above, the |
In #48921, Patatrack quadraplet pixel tracks were made the default in CMSSW, so the alpaka modifier was rendered useless in a quite a few workflows which were using it to enable Patatrack pixel tracking. This PR removes the alpaka procModifier from these workflows. One workflow is completely removed, as it was duplicate of another, and that leads to a small change in the workflow numbering.
The PR was validated by making sure that all the modified workflows succeed.
FYI @rovere and @waredjeb: Since the
alpakaprocModifier is used in Phase 2 HLT to enable the HGCal heterogeneous reconstruction, I wanted to ask whether it is useful to keep it in any of the modified workflows.