Fix hard-scatter vertex ID in HTXSRivetProducer #49759
Open
+89
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
In certain 2024 MC samples, the HTXS labels for all events are set to
0: UNKNOWN, see e.g.ZH-Hto2G:This stems from changes made to transition from HepMC2 -> HepMC3 for these samples, where
signal_process_vertex()was removed. Instead, it was assumed that the first vertex inGenEventis the hard-scatter vertex. This is not always the case and causes the Rivet routine to fail. This PR moves the existing (correct) logic from the Rivet routine itself into a utility function that can then be used by the producer.PR validation:
0: UNKNOWNlabelsIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: