Skip to content

[do noit merge] added a junk line to the file in the Alignment for bot testing #49771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
raoatifshad wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[do noit merge] added a junk line to the file in the Alignment for bot testing #49771

raoatifshad wants to merge 4 commits into from
+2 −0

Conversation

@raoatifshad
Copy link

@raoatifshad raoatifshad commented Jan 12, 2026 •
edited by smuzaffar
Loading



@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

please test

@cmsbuild cmsbuild added this to the CMSSW_16_1_X milestone Jan 12, 2026
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

A new Pull Request was created by raoatifshad for master.

It involves the following packages:

  • Alignment/CocoaFit (alca)

Alejandro1400, JanChyczynski, arunhep, atpathak, perrotta can you please review it and eventually sign? Thanks.
mmusich, rsreds, tocheng, yuanchao this is something you requested to watch as well.
ftenchini, mandrenguyen, sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47364

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

please test

@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

code-checks

@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

code-checks

@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

please test

@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

please hold

@smuzaffar smuzaffar changed the title added a junk line to the file in the Alignment for bot testing [do noit merge] added a junk line to the file in the Alignment for bot testing Jan 12, 2026
@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

Pull request #49771 was updated. Dr15Jones, cmsbuild, ftenchini, makortel, mandrenguyen, sextonkennedy, smuzaffar can you please check and sign again.

The following packages are now also affected:

  • Utilities/ReleaseScripts (core)

Dr15Jones, makortel, smuzaffar can you please review and sign?

wddgit this is something you requested to watch as well.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

Pull request has been put on hold by raoatifshad
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

please unhold

@cmsbuild cmsbuild removed the hold label Jan 12, 2026
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47383

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47385

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47387

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47390

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47391

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47392

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47393

@smuzaffar
Copy link
Contributor

smuzaffar commented Jan 12, 2026

looks like ew bot is keep on triggering code-checks . @raoatifshad can you check cms-sw/cms-bot#2626 changes to figure out why bot is keep on trigerring code-checks?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47396

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47397

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47399

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47401

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47402

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47405

@smuzaffar smuzaffar mentioned this pull request Jan 12, 2026
Open
@raoatifshad
Copy link
Author

raoatifshad commented Jan 12, 2026

please test

@iarspider
Copy link
Contributor

iarspider commented Jan 12, 2026 •
edited
Loading

@raoatifshad the bot is ignoring this PR. You need to retrigger the Jenkins job with "CMS_BOT_FORCE_FLAG" checked. But for now please don't do anything, I'm preparing a fix (and a test for it).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

Pull request #49771 was updated. Dr15Jones, cmsbuild, ftenchini, makortel, mandrenguyen, sextonkennedy, smuzaffar can you please check and sign again.

The following packages are now also affected:

  • Utilities/ReleaseScripts (core)

Dr15Jones, makortel, smuzaffar can you please review and sign?

wddgit this is something you requested to watch as well.

@iarspider
Copy link
Contributor

iarspider commented Jan 12, 2026

code-checks
not triggered automatically b/c https://cmssdt.cern.ch/jenkins/job/cms-bot/1945717/console failed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49771/47413

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2026

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-946e5b/50537/summary.html
COMMIT: 1f4ddcb
CMSSW: CMSSW_16_1_X_2026-01-12-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49771/50537/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
250202.181 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4167425
  • DQMHistoTests: Total failures: 81
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4167324
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

alca-pending code-checks-approved core-pending orp-pending pending-signatures tests-approved

Projects

None yet

Milestone

CMSSW_16_1_X

Development

Successfully merging this pull request may close these issues.

5 participants

@raoatifshad @cmsbuild @smuzaffar @iarspider @RaoMAtifShad