Skip to content

Conversation

@fabiocos
Copy link
Contributor

PR description:

Backport of #49801 to 14_2_X branch. The code has been adapted for the MtdSD part as the structure was originally different.

PR validation:

Code compiles, simple addition of MessageLogger printouts.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for CMSSW_14_2_X.

It involves the following packages:

  • SimG4CMS/Forward (simulation)
  • SimG4Core/Notification (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2026

cms-bot internal usage

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e84eea/50631/summary.html
COMMIT: c6c7bb9
CMSSW: CMSSW_14_2_X_2026-01-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49836/50631/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 55 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 2256
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3481446
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 2 / 44 workflows

@civanch
Copy link
Contributor

civanch commented Jan 15, 2026

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants