Open
Conversation
Add a constructor from Run3ScoutingElectron that populates kinematics, shower shapes, ID variables, track parameters, isolation, and ECAL crystal-level information. Scouting-derived quantities are stored as userFloats/userInts where GsfElectron members are not directly writable, and as dedicated private members for track and ECAL data. Provide universal accessors (trkEta, trkPhi, trkpMode, trketaMode, trkphiMode, trkqoverpModeError, seedId, nClusters, nCrystals) that dispatch to gsfTrack()/superCluster() for standard electrons and to the stored scouting values for scouting electrons, controlled by an isScoutingElectron() flag. Scouting-only quantities with no standard equivalent (energyMatrix, timingMatrix, detIds, rechitZeroSuppression) keep their scouting-prefixed accessors.
Add a constructor from Run3ScoutingPhoton that populates kinematics, shower shapes, energy variables, and isolation. Scouting-derived quantities are stored as userFloats where reco::Photon members are not directly writable, and as dedicated private members for ECAL crystal data. Provide universal accessors (seedId, nClusters, nCrystals) that dispatch to superCluster() for standard photons and to stored scouting values for scouting photons, controlled by an isScoutingPhoton() flag. Scouting-only quantities with no standard equivalent (energyMatrix, timingMatrix, detIds, rechitZeroSuppression) keep their scouting- prefixed accessors.
… since scouting jets don't have constituent indices filled. Still can be useful in the future.
…it to fill PackedCandidate tracking info
…it to fill PackedCandidate tracking info
Contributor
Author
|
@ftorrresd, @battibass, how can we proceed with the PR? We would like to start integrating it with BPHNano and it will be cleaner to keep the two as separate PRs if possible. |
Contributor
|
please test with cms-sw/cms-bot#2712 |
cmsbuild
added
tests-started
requires-external
and removed
tests-pending
new-package-pending
labels
Contributor
|
@drkovalskyi The code-checks looks unrelated to the addition of the new package. Can you run the usual |
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-started
requires-external
code-checks-rejected
labels
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50307/48791
|
Contributor
|
Pull request #50307 was updated. @Moanwar, @battibass, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @ftorrresd, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again. |
Contributor
|
please test |
Contributor
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
cmsbuild
added
operations-approved
tests-approved
and removed
operations-pending
tests-started
labels
Contributor
|
@cms-sw/xpog-l2 @cms-sw/reconstruction-l2 Can you please have a look? Would like to get this in before building a pre-release. |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Convert Run3 scouting data to standard MiniAOD format so that analysts can use the same accessors regardless of whether objects came from standard reconstruction or scouting.
What this PR does:
For details on motivation and content optimization see https://indico.cern.ch/event/1646385/#4-proposal-for-miniaod-from-hl
PR validation: