Skip to content

[16_0_X] Add safeguard in final step of Alpaka PF multi-depth clustering when 0 clusters are present #50604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsamudio wants to merge 2 commits into
base: CMSSW_16_0_X
Choose a base branch
from
+33 −27
Open

[16_0_X] Add safeguard in final step of Alpaka PF multi-depth clustering when 0 clusters are present #50604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
849764d
Add protection for case where no clusters are present
jsamudio Mar 31, 2026
b3414e9
Add zero-initialization of SoAs which do not process through Alpaka k…
jsamudio Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 31 additions & 27 deletions RecoParticleFlow/PFClusterProducer/plugins/LegacyMultiDepthPFClusterProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,45 +149,49 @@ void LegacyMultiDepthPFClusterProducer::produce(edm::Event& event, const edm::Ev

auto const rechitsHandle = event.getHandle(recHitsLabel_);

// Build PFClusters in legacy format
int sizePFC = pfClusterSoA.metadata().size();

std::unordered_map<int, int> nTopoSeeds;
nTopoSeeds.reserve(pfClusterSoA.nSeeds());
if (sizePFC != 0) {
// Build PFClusters in legacy format

for (int i = 0; i < pfClusterSoA.nSeeds(); ++i)
nTopoSeeds[pfClusterSoA[i].topoId()]++;
std::unordered_map<int, int> nTopoSeeds;
nTopoSeeds.reserve(pfClusterSoA.nSeeds());

// Looping over SoA PFClusters to produce legacy PFCluster collection
auto const& recHits = *rechitsHandle;
for (int i = 0; i < pfClusterSoA.nSeeds(); ++i)
nTopoSeeds[pfClusterSoA[i].topoId()]++;

for (int i = 0; i < pfClusterSoA.nSeeds(); i++) {
unsigned int seedIdx = pfClusterSoA[i].seedRHIdx();
// Looping over SoA PFClusters to produce legacy PFCluster collection
auto const& recHits = *rechitsHandle;

if (seedIdx >= static_cast<unsigned>(nRH))
continue;
for (int i = 0; i < pfClusterSoA.nSeeds(); i++) {
unsigned int seedIdx = pfClusterSoA[i].seedRHIdx();

reco::PFCluster temp;
if (seedIdx >= static_cast<unsigned>(nRH))
continue;

temp.setSeed(recHits[seedIdx].detId());
reco::PFCluster temp;

int const offset = pfClusterSoA[i].rhfracOffset();
int const size = pfClusterSoA[i].rhfracSize();
temp.setSeed(recHits[seedIdx].detId());

for (int k = offset; k < (offset + size); k++) { // Looping over PFRecHits in the same topo cluster
if (pfRecHitFractionSoA[k].pfrhIdx() < nRH && pfRecHitFractionSoA[k].pfrhIdx() > -1 &&
pfRecHitFractionSoA[k].frac() > 0.0f) {
const reco::PFRecHitRef& refhit = reco::PFRecHitRef(rechitsHandle, pfRecHitFractionSoA[k].pfrhIdx());
temp.addRecHitFraction(reco::PFRecHitFraction(refhit, pfRecHitFractionSoA[k].frac()));
int const offset = pfClusterSoA[i].rhfracOffset();
int const size = pfClusterSoA[i].rhfracSize();

for (int k = offset; k < (offset + size); k++) { // Looping over PFRecHits in the same topo cluster
if (pfRecHitFractionSoA[k].pfrhIdx() < nRH && pfRecHitFractionSoA[k].pfrhIdx() > -1 &&
pfRecHitFractionSoA[k].frac() > 0.0f) {
const reco::PFRecHitRef& refhit = reco::PFRecHitRef(rechitsHandle, pfRecHitFractionSoA[k].pfrhIdx());
temp.addRecHitFraction(reco::PFRecHitFraction(refhit, pfRecHitFractionSoA[k].frac()));
}
}
}

// Now PFRecHitFraction of this PFCluster is set. Now compute calculateAndSetPosition (energy, position etc)
if (nTopoSeeds[pfClusterSoA[i].topoId()] == 1 && allCellsPositionCalc_) {
allCellsPositionCalc_->calculateAndSetPosition(temp, paramPF);
} else {
positionCalc_->calculateAndSetPosition(temp, paramPF);
// Now PFRecHitFraction of this PFCluster is set. Now compute calculateAndSetPosition (energy, position etc)
if (nTopoSeeds[pfClusterSoA[i].topoId()] == 1 && allCellsPositionCalc_) {
allCellsPositionCalc_->calculateAndSetPosition(temp, paramPF);
} else {
positionCalc_->calculateAndSetPosition(temp, paramPF);
}
out.emplace_back(std::move(temp));
}
out.emplace_back(std::move(temp));
}

event.emplace(legacyPfClustersToken_, std::move(out));
Expand Down
2 changes: 2 additions & 0 deletions RecoParticleFlow/PFClusterProducer/plugins/alpaka/PFMultiDepthClusterSoAProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
*pfcl_size_);
} else {
outPFClusters = std::make_unique<reco::PFClusterDeviceCollection>(event.queue(), 0);
outPFClusters->zeroInitialise(event.queue());
outPFRHFractions = std::make_unique<reco::PFRecHitFractionDeviceCollection>(event.queue(), 0);
outPFRHFractions->zeroInitialise(event.queue());
}

event.emplace(outputPFClusterSoA_Token_, std::move(*outPFClusters));
Expand Down