Skip to content

TestObjects: Added missing dependency to fix the failing unit test#50634

Open
smuzaffar wants to merge 1 commit intocms-sw:masterfrom
smuzaffar:TestIOPoolInputNoParentDictionary-fix
Open

TestObjects: Added missing dependency to fix the failing unit test#50634
smuzaffar wants to merge 1 commit intocms-sw:masterfrom
smuzaffar:TestIOPoolInputNoParentDictionary-fix

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

@smuzaffar smuzaffar commented Apr 2, 2026

This should fix the failing unit test TestIOPoolInputNoParentDictionary in 16.1.X IBs. This PR proposes to add the missing dependency on DataFormats/TestObjects for the extra dictionaries build by the unit test.

This dependency was removed in #50609 ( as a part of cleanup) but it was actually needed by the extra dictionaries build by the unit test.

Local build and tests are successful

Creating test log file logs/el8_amd64_gcc13/testing.log
Pass    3s ... DataFormats/TestObjects/Enum_t
Pass    5s ... IOPool/Input/TestFileOpenErrorExitCode
Pass   47s ... IOPool/Input/TestIOPoolInputNoParentDictionary
Pass   10s ... IOPool/Input/TestIOPoolInputReducedProcessHistoryHardwareResources
Pass   30s ... IOPool/Input/TestIOPoolInputReducedProcessHistoryVersion
Pass    8s ... IOPool/Input/TestIOPoolInputRefProductIDMetadataConsistency
Pass    4s ... IOPool/Input/TestIOPoolInputRepeating
Pass   22s ... IOPool/Input/TestIOPoolInputSchemaEvolution
Pass   36s ... IOPool/Input/TestPoolInput
Pass    5s ... IOPool/Input/TestPoolInputMergeHeterogeneousFiles
Pass    3s ... IOPool/Input/TestPoolInputMultiLumi
Pass   74s ... IOPool/Input/TestPoolInputOldFormat
Pass    4s ... IOPool/Input/TestPoolInputOverlappingLumis
Pass   23s ... IOPool/Input/TestPoolInputRunPerLumi

@cmsbuild cmsbuild added this to the CMSSW_16_1_X milestone Apr 2, 2026
@smuzaffar
Copy link
Copy Markdown
Contributor Author

test parameters:

  • addpkg = IOPool/Input

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 2, 2026

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • DataFormats/TestObjects (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@smuzaffar
Copy link
Copy Markdown
Contributor Author

FYI @Dr15Jones

@smuzaffar
Copy link
Copy Markdown
Contributor Author

urgent

@cms-sw/orp-l2 , this should fix the failing unit tests in IBs

@cmsbuild cmsbuild added the urgent label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants