TestObjects: Added missing dependency to fix the failing unit test#50634
Open
smuzaffar wants to merge 1 commit intocms-sw:masterfrom
Open
TestObjects: Added missing dependency to fix the failing unit test#50634smuzaffar wants to merge 1 commit intocms-sw:masterfrom
smuzaffar wants to merge 1 commit intocms-sw:masterfrom
Conversation
Contributor
Author
|
test parameters:
|
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50634/48834 |
Contributor
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
Author
|
please test |
Contributor
Author
|
FYI @Dr15Jones |
Contributor
Author
|
urgent @cms-sw/orp-l2 , this should fix the failing unit tests in IBs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the failing unit test
TestIOPoolInputNoParentDictionaryin 16.1.X IBs. This PR proposes to add the missing dependency onDataFormats/TestObjectsfor the extra dictionaries build by the unit test.This dependency was removed in #50609 ( as a part of cleanup) but it was actually needed by the extra dictionaries build by the unit test.
Local build and tests are successful