Enable interop #218

smuzaffar · 2025-02-18T10:57:55Z

No description provided.

Partially revert commit 8257f60, std::unique_ptr<Impl> requires a full type which is only available in JSONParser.cxx.

PDFTest has a std::unique_ptr<RooAbsPdf> which needs a complete type during destruction.

The term "index" is used in various other contexts. The functionality of the class is also inherently different from what is considered an "index" in database terms (where the name choice initially originated from). Hence, this rename should remove any naming ambiguity and better describe the actual functionality of the class.

... and inner classes to reflect the class name change from `RNTupleIndex` to `RNTupleJoinTable`.

To reflect the name change from `RNTupleIndex` to `RNTupleJoinTable`

To reflect the name change from `RNTupleIndex` to `RNTupleJoinTable` (and fix some typos along the way).

To reflect the name change from `RNTupleIndex` to `RNTupleJoinTable`

When using the `Extended()` keyword argument in `createHistogram()` the docs say it has the following effect: > Plot event yield instead of probability density (for extended pdfs only) However, to get yields out of the probability densities, one has to not only multiply with the total number of expected events, but also with the bin volumes. I don't understand why the bin volume multiplication is disable in *exactly* this case. This commit suggests to not do that anymore, in order to be able to correctly produce predicted yields histograms. Thanks to the following forum post for noticing this: https://root-forum.cern.ch/t/bin-content-of-pdf-and-generated-data/62370 This change of behavior is also mentioned in the release notes. A unit test to validate that the yield histogram can now be correctly created is also added.

Consistently use `RooAbsData::reduce()` overload that takes RooFit command arguments in the RooFit code. This allows us to deprecate all the other overloads one day, in the spirit of avoiding duplicate interfaces and user confusion. Also, avoid some code repetition in setting up the cut expressions for slicing in RooAbsReal.cxx and RooSimultaneous.cxx.

1. The RooAbsDataStore has a virtual function `tree()` which is not meaningful for a general data store. This function should be removed. 2. The RooTreeDataStore has one `const` version on `tree()` and one non-const version. One returns a pointer and the other a reference, which is very confusing. 3. The RooTreeDataStore has some methods that just forward to the underlying TTree, but they were not used. Changes to the data store classes can be made without impacting users because they are implementation details of the RooFit dataset classes.

Using this function is introducing memory leaks too easily if used wrong, because it returns a `RooArgsSet *` that needs to be deleted by the caller without documenting this. This commit suggests to simply remove this function, after all one could just call `addColumn()` in a loop and be safe.

The `RooStats::HLFactory` class was deprecated and will be removed in ROOT 6.38. It provided little advantage over using the RooWorkspace directly or any of the other higher-level frameworks that exists in the RooFit ecosystem.

Since this class is deprecated now.

LLVM_DIR can be set as a hint for find_package, but LLVMConfig.cmake sets LLVM_CMAKE_DIR.

This gives CMake full information about (transitive) library dependencies. Fixes root-project#17461

It was modified in commit 5410bb4, but that never worked because it was also added to the list of removed options, which will issue a FATAL_ERROR if enabled.

This was missed in commit b3bf099 ("[cmake] Remove deprecated cxxmodules option").

They were spelled as *cxx*, until cxx11 and cxx14 were removed in favor of CMAKE_CXX_STANDARD.

This was deprecated in CMake version 3.20.0 https://cmake.org/cmake/help/latest/module/AddFileDependencies.html

In normal browser closing browser window immediately destroy complete TRootBrowser object. One need to reset TBrowser::fImp pointer to avoid access to invalid pointer

If implementation was deleted - create and show new one

Causes probems on client side

and be more verbose

smuzaffar · 2025-02-18T10:58:13Z

please test for CMSSW_15_1_ROOT6_X

iarspider · 2025-02-18T11:09:03Z

please test for CMSSW_15_1_ROOT6_X

cmsbuild · 2025-02-18T11:09:40Z

Pull request #218 was updated.

cmsbuild · 2025-02-18T11:11:51Z

Pull request #218 was updated.

cmsbuild · 2025-02-18T11:20:41Z

Pull request #218 was updated.

by linking clangCppInterOp in libCling

smuzaffar · 2025-02-18T11:23:03Z

please test for CMSSW_15_1_ROOT6_X

cmsbuild · 2025-02-18T11:23:14Z

Pull request #218 was updated.

cmsbuild · 2025-02-18T14:23:34Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2059b7/44463/summary.html
COMMIT: 2887ee4
CMSSW: CMSSW_15_1_ROOT6_X_2025-02-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/218/44463/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2059b7/44463/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2059b7/44463/git-merge-result

Build

I found compilation error when building:

>> Compiling  src/PhysicsTools/TagAndProbe/src/TagProbePairMaker.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_1_ROOT6_X_2025-02-17-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_ROOT6_X_2025-02-17-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02877/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_ROOT6_X_2025-02-17-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-f5097dd95ee1f7dc3d9e4812dffe37d6/include/LCG -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.2.0-b081818336b70095080b83065d50ff0d/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-96a02191111b66819e07de179cb25a0e/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/curl/7.79.0-d8c0d5017cfad573d276c56bd08114b8/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hepmc/2.06.10-262d73524c32528e87adc31a98f68d52/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls/2019.08-e6beae7d560007d8bb20c2cf88bfde9a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls4mlEmulatorExtras/1.1.4-7f1f5ec35d8cc94e9bab71c7ff9456f1/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-65c8c57c947cd5d477d8185c25a38587/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-9b0f135342cfe979b6500c59f501774e/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/utm/utm_0.13.0-72ee52d69791ed49755d3e16b24e6f1e/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hepmc3/3.2.7-f10dce5b16f0246f8cac8378933b9681/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/PhysicsTools/TagAndProbe/src/PhysicsToolsTagAndProbe/TagProbePairMaker.cc.d src/PhysicsTools/TagAndProbe/src/TagProbePairMaker.cc -o tmp/el8_amd64_gcc12/src/PhysicsTools/TagAndProbe/src/PhysicsToolsTagAndProbe/TagProbePairMaker.cc.o
>> Compiling  src/PhysicsTools/TagAndProbe/src/ZGeneratorLineShape.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_1_ROOT6_X_2025-02-17-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_ROOT6_X_2025-02-17-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02877/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_ROOT6_X_2025-02-17-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-f5097dd95ee1f7dc3d9e4812dffe37d6/include/LCG -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.2.0-b081818336b70095080b83065d50ff0d/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-96a02191111b66819e07de179cb25a0e/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/curl/7.79.0-d8c0d5017cfad573d276c56bd08114b8/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hepmc/2.06.10-262d73524c32528e87adc31a98f68d52/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls/2019.08-e6beae7d560007d8bb20c2cf88bfde9a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls4mlEmulatorExtras/1.1.4-7f1f5ec35d8cc94e9bab71c7ff9456f1/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-65c8c57c947cd5d477d8185c25a38587/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-9b0f135342cfe979b6500c59f501774e/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/utm/utm_0.13.0-72ee52d69791ed49755d3e16b24e6f1e/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hepmc3/3.2.7-f10dce5b16f0246f8cac8378933b9681/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/PhysicsTools/TagAndProbe/src/PhysicsToolsTagAndProbe/ZGeneratorLineShape.cc.d src/PhysicsTools/TagAndProbe/src/ZGeneratorLineShape.cc -o tmp/el8_amd64_gcc12/src/PhysicsTools/TagAndProbe/src/PhysicsToolsTagAndProbe/ZGeneratorLineShape.cc.o
src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc: In member function 'std::string TagProbeFitter::calculateEfficiency(std::string, const std::vector >&, const std::vector >&, std::vector >&, std::map, std::vector >&, std::map, std::vector > >&, std::vector >&)':
src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc:376:44: error: 'class RooTreeDataStore' has no member named 'GetEntries'; did you mean 'sumEntries'?
  376 |         for (unsigned int i = 0; i < store.GetEntries(); ++i) {
      |                                            ^~~~~~~~~~
      |                                            sumEntries
gmake: *** [tmp/el8_amd64_gcc12/src/PhysicsTools/TagAndProbe/src/PhysicsToolsTagAndProbe/TagProbeFitter.cc.o] Error 1
>> Building LCG reflex dict from header file src/PhysicsTools/TagAndProbe/src/classes.h

aaronj0 · 2025-02-18T14:33:36Z

Looks like GetEntries was dropped from RooTreeDataStore in root-project@2d090af

Pinging @guitargeek

I assume this is fixed by doing

store.tree()->GetEntries()

guitargeek · 2025-02-18T15:35:16Z

Thanks for pinging. The RooTreeDataStore should not be used directly:

Use RooDataSet instead of RooTreeDataStore cmssw#47388

smuzaffar · 2025-02-18T22:24:26Z

please test with cms-sw/cmssw#47390 for CMSSW_15_1_ROOT6_X

guitargeek · 2025-02-18T22:26:59Z

Hi sorry @smuzaffar for all the PRs that were closed again. I realized there are some more fundamental issues with the Tag and Probe fitter, bit I'll address them at a later point after the hotfix

cmsbuild · 2025-02-19T05:20:31Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2059b7/44494/summary.html
COMMIT: 2887ee4
CMSSW: CMSSW_15_1_ROOT6_X_2025-02-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/218/44494/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2059b7/44494/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2059b7/44494/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestRunnerDataFormatsFWLite had ERRORS

Comparison Summary

Summary:

You potentially added 222 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1003 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3902732
DQMHistoTests: Total failures: 470
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 3902240
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 109179.54199999999 KiB( 48 files compared)
DQMHistoSizes: changed ( 16834.0,... ): -1686.929 KiB HLT/BTV
DQMHistoSizes: changed ( 24834.911,... ): 13600.762 KiB HLT/TrackerPhase2OTTrackingRecHitV
DQMHistoSizes: changed ( 24834.911,... ): 2468.031 KiB HLT/TrackerPhase2ITTrackingRecHitV
DQMHistoSizes: changed ( 24834.911,... ): 2464.594 KiB HLT/TrackerPhase2ITRecHitV
DQMHistoSizes: changed ( 24834.911,... ): 183.994 KiB HLT/TrackerPhase2OTClusterV
DQMHistoSizes: changed ( 24834.911,... ): 41.480 KiB HLT/TrackerPhase2ITClusterV
DQMHistoSizes: changed ( 24834.911,... ): 0.020 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 24834.911,... ): 0.020 KiB MessageLogger/Warnings
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: found differences in 6 / 47 workflows

hahnjo and others added 25 commits February 17, 2025 12:19

[RF] Outline destructor of TJSONTree::Node

cd36aed

Partially revert commit 8257f60, std::unique_ptr<Impl> requires a full type which is only available in JSONParser.cxx.

[RF] Add missing include to test

4c1dff5

PDFTest has a std::unique_ptr<RooAbsPdf> which needs a complete type during destruction.

[ntuple] Rename RNTupleJoinTable data members

c4f1a13

... and inner classes to reflect the class name change from `RNTupleIndex` to `RNTupleJoinTable`.

[ntuple] Update RNTupleJoinTable error messages

66c9fd0

To reflect the name change from `RNTupleIndex` to `RNTupleJoinTable`

[ntuple] Update RNTupleJoinTable documentation

1e0b3f9

To reflect the name change from `RNTupleIndex` to `RNTupleJoinTable` (and fix some typos along the way).

[ntuple] Update ntuple_join_table test variables

4bb3964

To reflect the name change from `RNTupleIndex` to `RNTupleJoinTable`

[RF] Support non-uniform binning in RooAbsReal::fillHistogram()

2f06c04

[RF] Deprecate RooStats::HLFactory

6166d3f

The `RooStats::HLFactory` class was deprecated and will be removed in ROOT 6.38. It provided little advantage over using the RooWorkspace directly or any of the other higher-level frameworks that exists in the RooFit ecosystem.

[RF] Remove RooStats::HLFactory tutorials

8bf3b0b

Since this class is deprecated now.

[cling] Print correct LLVM CMake directory

bb4fde0

LLVM_DIR can be set as a hint for find_package, but LLVMConfig.cmake sets LLVM_CMAKE_DIR.

[interpreter] Use find_package({LLVM,Clang})

5c51aaf

This gives CMake full information about (transitive) library dependencies. Fixes root-project#17461

[cmake] Remove warning about python option

85bba3e

It was modified in commit 5410bb4, but that never worked because it was also added to the list of removed options, which will issue a FATAL_ERROR if enabled.

[cmake] Add cxxmodules to list of removed options

6a6a17e

This was missed in commit b3bf099 ("[cmake] Remove deprecated cxxmodules option").

[cmake] Clean remainders of removed cxxmodules option

a53ff61

Remove more unset options from config/Makefile.in

4f088de

They were spelled as *cxx*, until cxx11 and cxx14 were removed in favor of CMAKE_CXX_STANDARD.

[cling][NFC] Replace use of deprecated AddFileDependencies

64a148d

This was deprecated in CMake version 3.20.0 https://cmake.org/cmake/help/latest/module/AddFileDependencies.html

Reset TBrowser::fImp pointer when close browser window

e47e2cc

In normal browser closing browser window immediately destroy complete TRootBrowser object. One need to reset TBrowser::fImp pointer to avoid access to invalid pointer

Implement TBrowser::Draw()

7b9527f

If implementation was deleted - create and show new one

Do not send init message twice in RBrowser

0229f00

Causes probems on client side

[skip-ci] fix link to PRs (root-project#17742)

950607a

and be more verbose

cmsbuild added orp-pending pending-signatures externals-pending tests-started labels Feb 18, 2025

aaronj0 force-pushed the enable-interop branch from 546d1c8 to bb60a47 Compare February 18, 2025 11:09

aaronj0 force-pushed the enable-interop branch from bb60a47 to 3f0dbb6 Compare February 18, 2025 11:11

aaronj0 force-pushed the enable-interop branch from 3f0dbb6 to 755868a Compare February 18, 2025 11:20

aaronj0 added 3 commits February 18, 2025 12:22

Enable the CppInterOp library

471007c

[TCling] Allow InterOp to access ROOT's interpreter

d85b42f

by linking clangCppInterOp in libCling

[ci] Add github workflow to check diff against upstream CppInterOp

2887ee4

aaronj0 force-pushed the enable-interop branch from 755868a to 2887ee4 Compare February 18, 2025 11:22

cmsbuild added tests-started and removed tests-pending labels Feb 18, 2025

smuzaffar mentioned this pull request Feb 18, 2025

Enable CppInterOp root-project/root#16814

Merged

5 tasks

cmsbuild added tests-rejected and removed tests-started labels Feb 18, 2025

cmsbuild added the requires-external label Feb 18, 2025

cmsbuild added tests-started and removed tests-rejected labels Feb 18, 2025

cmsbuild added tests-rejected and removed tests-started labels Feb 19, 2025

smuzaffar closed this Feb 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable interop #218

Enable interop #218

smuzaffar commented Feb 18, 2025

smuzaffar commented Feb 18, 2025

iarspider commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

smuzaffar commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

aaronj0 commented Feb 18, 2025 •

edited

Loading

guitargeek commented Feb 18, 2025

smuzaffar commented Feb 18, 2025

guitargeek commented Feb 18, 2025

cmsbuild commented Feb 19, 2025

Enable interop #218

Enable interop #218

Conversation

smuzaffar commented Feb 18, 2025

smuzaffar commented Feb 18, 2025

iarspider commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

smuzaffar commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

cmsbuild commented Feb 18, 2025

Build

aaronj0 commented Feb 18, 2025 • edited Loading

guitargeek commented Feb 18, 2025

smuzaffar commented Feb 18, 2025

guitargeek commented Feb 18, 2025

cmsbuild commented Feb 19, 2025

Unit Tests

Comparison Summary

aaronj0 commented Feb 18, 2025 •

edited

Loading