This repository was archived by the owner on Sep 27, 2019. It is now read-only.
Check database existence before connecting#1165
Open
schedutron wants to merge 1 commit intocmu-db:masterfrom
Open
Check database existence before connecting#1165schedutron wants to merge 1 commit intocmu-db:masterfrom
schedutron wants to merge 1 commit intocmu-db:masterfrom
Conversation
schedutron
changed the title
Contributor
Author
|
@pmenon Can you please hint me on how do I accomplish this check? I basically need to check for membership in a set of available databases' names. |
Member
|
@ChTimTsubasa Can you help @schedutron with this? |
Member
|
The place you might want to insert the code to check the database existence is in https://github.com/cmu-db/peloton/blob/master/src/network/postgres_protocol_handler.cpp#L1118, where the protocol handler is checking the existence of the packet and send back a response. You might want to check what would be the correct response to send back. Using Wireshark on psql and Postgres would help. |
Contributor
|
Related to #1164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1164. @pmenon Can you please add the
in progresslabel? Also, to check for database existence intraffic_cop.h, we need access to theCatalogobject, right? Can you please hint me on how do we do that?