This repository was archived by the owner on Sep 27, 2019. It is now read-only.
Handle EXPLAIN in the optimizer and executor#1357
Open
chenboy wants to merge 13 commits intocmu-db:masterfrom
Open
Handle EXPLAIN in the optimizer and executor#1357chenboy wants to merge 13 commits intocmu-db:masterfrom
chenboy wants to merge 13 commits intocmu-db:masterfrom
Conversation
… of the sql statement's not correctly set
Contributor
Author
|
Blocked by #1368 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the handling logic of
EXPLAINfrom the network layer to the execution layer. One reason for this is we don't want to duplicate the logic for different protocols, e.g. psql and JDBC, as it is mentioned in #1350.Two test cases are added, one of which is a SQL test for the functionality of the
EXPLAINexecutor. Since we also touch the network layer, an end-to-end test is also added to make sure we didn't break anything in the network layer.