Skip to content

docs: initial commit for "search" #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

rchincha
Copy link
Contributor

This work is relevant for both CNCF (artifacts) and OCI (distribution spec)

We can iterate under CNCF for this part while being compatible with OCI.

@rchincha
Copy link
Contributor Author

rchincha commented Jan 29, 2024

@rchincha
Copy link
Contributor Author

Maybe /v2/_artifacts?

@rchincha
Copy link
Contributor Author

oras-project/oras#1257

@rchincha
Copy link
Contributor Author

rchincha commented Jan 29, 2024

https://github.com/project-zot/zot/blob/main/pkg/extensions/search/search.md

zot already supports these but specific to zot

rchincha added a commit to rchincha/zot that referenced this pull request Jan 29, 2024
cncf-tags/wg-artifacts#34

An experiment to make this possible

Signed-off-by: Ramkumar Chinchani <[email protected]>
rchincha added a commit to rchincha/zot that referenced this pull request Jan 29, 2024
cncf-tags/wg-artifacts#34

An experiment to make this possible

Signed-off-by: Ramkumar Chinchani <[email protected]>
@rchincha
Copy link
Contributor Author

project-zot/zot#2209

Reachable as follows ...

$ curl http://localhost:8080/v2/_artifacts/ext/search

{"errors":[{"message":"no operation provided","extensions":{"code":"GRAPHQL_VALIDATION_FAILED"}}],"data":null}

@sabre1041
Copy link

This is a great start @rchincha

Would you be able to take a look at the CI failures?

@rchincha rchincha force-pushed the search branch 2 times, most recently from 9068a8b to 99901d3 Compare February 12, 2024 19:26
@rchincha rchincha marked this pull request as ready for review February 12, 2024 19:29
@rchincha rchincha requested a review from afflom as a code owner February 12, 2024 19:29
This work is relevant for both CNCF (artifacts) and OCI (distribution
spec)

We can iterate under CNCF for this part while being compatible with OCI.

Signed-off-by: Ramkumar Chinchani <[email protected]>
Copy link

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as a starting point. I'm fine with merging and iterating.

@rchincha rchincha merged commit c97ed8b into cncf-tags:main Apr 26, 2024
rchincha added a commit to rchincha/zot that referenced this pull request May 24, 2024
cncf-tags/wg-artifacts#34

An experiment to make this possible

Signed-off-by: Ramkumar Chinchani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants