Skip to content

Conversation

@dprotaso
Copy link

@dprotaso dprotaso commented Sep 4, 2025

No description provided.

@dprotaso dprotaso force-pushed the knative-logo-updates branch from 3bee15f to c3398d5 Compare September 4, 2025 16:34
@dprotaso
Copy link
Author

dprotaso commented Sep 4, 2025

cc @aliok @evankanderson @matzew (Knative Steering)

@aliok
Copy link
Member

aliok commented Sep 5, 2025

Looks good to me.

I thought there might be links to existing images and looked for ways to find those references. I wasn't able to find a good way.

@aliok
Copy link
Member

aliok commented Sep 5, 2025

/lgtm

Copy link

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVGs don't quite seem right. Let me know if you end up wanting help.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On GitHub, the font is rendering bolder than the .png and with an incorrect bounding box. I think it's picking the wrong font. You may need to embed the font into the SVG using:

<style>
    @import url('https://fonts.cdnfonts.com/css/satoshi');
</style>

or:

<style>
@font-face {
    font-family: 'Satoshi';
    font-style: normal;
    font-weight: 500;
    src: local('Satoshi'), url('https://fonts.cdnfonts.com/s/85546/Satoshi-Medium.woff') format('woff');
}
</style>

(Assuming you're using medium weight Satoshi)

or go into Inkscape and use "Convert to path", which will replace the text + font combination with a set of curves that match the text.

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just wanted to check in on this PR as it appears to have stalled a bit. @dprotaso, do you have time to look into @evankanderson's comments?

@evankanderson
Copy link

Dave, do you want me to PR those changes to your branch?

@dprotaso
Copy link
Author

dprotaso commented Oct 28, 2025 via email

@nate-double-u
Copy link
Member

#608 won't actually affect this PR, I thought it might, but this PR just affects the logos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants