-
Notifications
You must be signed in to change notification settings - Fork 368
include 'Knative' project name in horizontal and stacked artwork #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dave Protasowski <[email protected]>
3bee15f to
c3398d5
Compare
|
cc @aliok @evankanderson @matzew (Knative Steering) |
|
Looks good to me. I thought there might be links to existing images and looked for ways to find those references. I wasn't able to find a good way. |
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SVGs don't quite seem right. Let me know if you end up wanting help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On GitHub, the font is rendering bolder than the .png and with an incorrect bounding box. I think it's picking the wrong font. You may need to embed the font into the SVG using:
<style>
@import url('https://fonts.cdnfonts.com/css/satoshi');
</style>
or:
<style>
@font-face {
font-family: 'Satoshi';
font-style: normal;
font-weight: 500;
src: local('Satoshi'), url('https://fonts.cdnfonts.com/s/85546/Satoshi-Medium.woff') format('woff');
}
</style>
(Assuming you're using medium weight Satoshi)
or go into Inkscape and use "Convert to path", which will replace the text + font combination with a set of curves that match the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, just wanted to check in on this PR as it appears to have stalled a bit. @dprotaso, do you have time to look into @evankanderson's comments?
|
Dave, do you want me to PR those changes to your branch? |
|
Sure if that’s easier for you to do
…On Tue, Oct 28, 2025 at 16:47 Evan Anderson ***@***.***> wrote:
*evankanderson* left a comment (cncf/artwork#587)
<#587 (comment)>
Dave, do you want me to PR those changes to your branch?
—
Reply to this email directly, view it on GitHub
<#587 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAERARNEWDIFKLSOAU2ET33Z7I5NAVCNFSM6AAAAACFURQ7PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINJYGQZDANZYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
#608 won't actually affect this PR, I thought it might, but this PR just affects the logos. |
No description provided.