Parameterized page, header/menu and footer colors.#71
Open
Parameterized page, header/menu and footer colors.#71
Conversation
✅ Deploy Preview for dot-org-hugo-theme-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Pece Miloshev <pece@milosev.info>
pmilosev
force-pushed
the
background-colors
branch
from
bd9da84 to
50938c2
Compare
Signed-off-by: Pece Miloshev <pece@milosev.info>
Originally the page background colour was set by selecting only for elements of class 'page'. However this will miss all pages other than leaf pages. For example the FAQ in the example site has body with class 'faq page-section' and the BLOG 'blog page-section'. The commit is setting background colour to 'body' instead of just '.page'. Tests do not show any apparent issues. Alternatively one can use wild card selectors, but as CSS rookie I chose the simple solution. Signed-off-by: Pece Miloshev <pece.miloshev@nofuss.consulting>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page, header / menu and footer colors are currently hard-coded to
--whiteand--black.In order to change any of these colors a user of the theme needs to override portions of the SCSS.
To make things simpler, I added the following color vars:
--page-bacground-color,--menu-background-color,--submenu-background-colorand--footer-background-color.I updated the relevant SCSS code to use these vars instead of
--whiteand--black.