Adds hello bar to site by pulling data from CNCF main site #3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Abraham <[email protected]>
cjyabraham
requested review from
caniszczyk,
iamNoah1,
jihoon-seo,
nate-double-u and
seokho-son
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Chris Abraham <[email protected]>
jihoon-seo
added
enhancement
|
Closing this in favor of our new approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
In order to increase the reach of our ad campaigns we'd like to run a hello bar on the Glossary site and other CNCF subsites. This hello bar will be controlled from the settings in the CNCF main site. Subsites will pull these settings using an API call.