Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages and required Node version #3407

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Update packages and required Node version #3407

merged 1 commit into from
Mar 4, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 27, 2025

  • Updates all NPM packages except for Hugo, which will need to be addressed separately
  • Updates the required Node version to match the currently active LTS. (It should also correspond to the Node version required by Docsy, but doesn't atm.)
  • There are no changes to the generated site files as a result of these changes.

/cc @nate-double-u

@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit ca0bf2a
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/67c0d9509af0840008377ea4
😎 Deploy Preview https://deploy-preview-3407--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nate-double-u
nate-double-u approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @chalin

/lgtm

jihoon-seo
jihoon-seo approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me merge this.

@jihoon-seo jihoon-seo added the maintainers Use this label if PR requires maintainers to take action label Mar 4, 2025
@jihoon-seo jihoon-seo merged commit 3fe28c8 into cncf:main Mar 4, 2025
9 checks passed
@chalin chalin deleted the chalin-im-rw-nodejs-vers-2025-02-27 branch March 4, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

@jihoon-seo jihoon-seo jihoon-seo approved these changes

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

@iamNoah1 iamNoah1 Awaiting requested review from iamNoah1 iamNoah1 is a code owner

Assignees
No one assigned
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @nate-double-u @jihoon-seo