Skip to content

Conversation

@jtjackson
Copy link
Contributor

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Nov 3, 2025

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit f148cc6
🔍 Latest deploy log https://app.netlify.com/projects/cncfglossary/deploys/6908e612ec088600085f73e9
😎 Deploy Preview https://deploy-preview-3589--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@seokho-son
Copy link
Collaborator

Thanks! @jtjackson :)

LGTM!

Just need to make up your commit. the commit is not signed correctly.
Commit sha: 8c57e69, Author: Jay Jackson, Committer: Jay Jackson; The sign-off is missing.

To add your Signed-off-by line to every commit in this branch:

  • Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  • In your local branch, run: git rebase HEAD~1 --signoff
  • Force push your changes to overwrite the branch: git push --force-with-lease origin adding_sign_to_pod_term
    Summary

Signed-off-by: Jay Jackson <[email protected]>
@jtjackson jtjackson force-pushed the adding_sign_to_pod_term branch from 8c57e69 to f148cc6 Compare November 3, 2025 17:27
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jtjackson!

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me merge this PR. :)

@seokho-son seokho-son merged commit 35ebec6 into cncf:main Nov 3, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in CNCF glossary definition review board Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/en for English

Projects

Development

Successfully merging this pull request may close these issues.

3 participants