Skip to content

Conversation

@RobertKielty
Copy link
Contributor

Updates README to

  • describe CLOWarden usage for the CNCF GitHub Org.

  • Removes references to Sheriff.

  • Swaps out a reference to an article on Medium on how to find your CNCF Slack ID for one provided by Slack docs.

@RobertKielty RobertKielty self-assigned this Mar 1, 2024
@RobertKielty RobertKielty linked an issue Mar 1, 2024 that may be closed by this pull request
Copy link
Collaborator

@riaankleinhans riaankleinhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some proposed grammar changes

Note: the ```name: repo name``` does not necessarily appear as the first field in a repositories entry which can be confusing.
> [!IMPORTANT]
>
> - Invite users to join the CNCF Org *before you add them via a PR* to config.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Actually, this doesn't apply to the repositories section, only to the teams top level section (please see sample in my other comment).

Copy link
Collaborator

@riaankleinhans riaankleinhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@onlydole onlydole added the ok-to-test Apply if PR is validated safe to test label Mar 5, 2024
Copy link
Member

@onlydole onlydole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicks and suggestions.

README.md Outdated
Comment on lines 121 to 123
TODO Fix broken link here OR update this statement
Project names must exactly match [the landscape listing](https://landscape.cncf.io/card-mode?project=hosted).
TODO Are Category names missing?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be TODO comments, or is this section more of an FAQ or Troubleshooting section?

riaankleinhans and others added 2 commits March 8, 2024 08:49
Co-authored-by: Taylor Dolezal <[email protected]>
Signed-off-by: Riaan Kleinhans <[email protected]>
Co-authored-by: Taylor Dolezal <[email protected]>
Signed-off-by: Riaan Kleinhans <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Apply if PR is validated safe to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identify and remove references to Sheriff

5 participants