-
Notifications
You must be signed in to change notification settings - Fork 506
removes sheriff, adds CLOWarden to README #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Robert Kielty <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some proposed grammar changes
Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
| Note: the ```name: repo name``` does not necessarily appear as the first field in a repositories entry which can be confusing. | ||
| > [!IMPORTANT] | ||
| > | ||
| > - Invite users to join the CNCF Org *before you add them via a PR* to config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. Actually, this doesn't apply to the repositories section, only to the teams top level section (please see sample in my other comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nitpicks and suggestions.
README.md
Outdated
| TODO Fix broken link here OR update this statement | ||
| Project names must exactly match [the landscape listing](https://landscape.cncf.io/card-mode?project=hosted). | ||
| TODO Are Category names missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be TODO comments, or is this section more of an FAQ or Troubleshooting section?
Co-authored-by: Taylor Dolezal <[email protected]> Signed-off-by: Riaan Kleinhans <[email protected]>
Co-authored-by: Taylor Dolezal <[email protected]> Signed-off-by: Riaan Kleinhans <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Updates README to
describe CLOWarden usage for the CNCF GitHub Org.
Removes references to Sheriff.
Swaps out a reference to an article on Medium on how to find your CNCF Slack ID for one provided by Slack docs.