Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable i18n with fr(French) for website #601

Merged
merged 12 commits into from
Apr 4, 2024
Merged

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Apr 1, 2024

Like done with es here: #594, this PR is enabling the website in fr.

Here are the 2 pages translated in French to review at this stage:

  • website/config.toml
  • website/i18n/fr.toml

The other files are a copy of website/content/en into website/content/fr as-is, without any French translation for now (this will be done later in future associated PRs). What was also done is removing these 4 symlinks and the associated content was copied manually:

  • website/content/fr/wgs/platforms/glossary/
  • website/content/fr/wgs/platforms/maturity-model/
  • website/content/fr/wgs/platforms/whitepaper/
  • website/content/fr/wgs/operator/whitepaper

Also, these following are taken into account:

When this PR will be ready, the goal will be to have the reviews from:

  • @abangser and team for consistency with other entries
  • @antoine-sncf for the French translation
  • @guillermotti for his recent experience with the es translation
  • The existing French translation group (who translated the CNCF glossary recently)

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit b4e179c
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/660ed4f113283f0008a5cc9e
😎 Deploy Preview https://deploy-preview-601--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mathieu-benoit mathieu-benoit force-pushed the fr branch 2 times, most recently from e385bfc to 23d5f45 Compare April 1, 2024 12:42
@mathieu-benoit mathieu-benoit marked this pull request as ready for review April 1, 2024 12:43
@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Apr 1, 2024

Ready for your review when you have a minute @abangser and @antoine-sncf, thanks!

@mathieu-benoit
Copy link
Contributor Author

Actually back to draft, as I need to remove the symlinks like in there #599. Still working on this.

mathieu-benoit and others added 4 commits April 1, 2024 15:48
@mathieu-benoit mathieu-benoit marked this pull request as ready for review April 1, 2024 15:49
@mathieu-benoit
Copy link
Contributor Author

I think this is now ready for your review @abangser, @antoine-sncf and @guillermotti. Thanks!

Copy link

@guillermotti guillermotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good except that you may have pulled in one commit off main during a rebase. Specifically Try "exit 1" in both netlify.toml files to force all builds.

I think it may be ok (hence the approve) but it may make history look a bit funny!

Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, need to block after learning about the URL field causing issues on the Spanish translation!

I think it's a small fix, but want to try and learn from that.

The test will be if opening up the maturity model shows as a default language of English or not in the language drop down.

Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @mathieu-benoit! Can confirm that the languages do work correctly, though as you can see in #608 I did spot an unassociated bug which may require a rebase depending on when this gets added.

Very happy for this to be merged now though as it has some french native reviews and appears to work on testing 🙌

Copy link
Contributor

@angellk angellk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@angellk angellk merged commit 3c35b30 into cncf:main Apr 4, 2024
6 checks passed
@mathieu-benoit mathieu-benoit deleted the fr branch April 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants