-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update website to reflect correct meeting time #607
Conversation
✅ Deploy Preview for tag-app-delivery ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: lianmakesthings <[email protected]>
Signed-off-by: lianmakesthings <[email protected]>
Signed-off-by: lianmakesthings <[email protected]>
Signed-off-by: lianmakesthings <[email protected]>
Signed-off-by: lianmakesthings <[email protected]>
c96b49c
to
86dda07
Compare
Action RequiredYou are adding or updating English content so please take the following actions for other languages.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lianmakesthings
The Japanese translation looks fine to me!👍
Anyway, I'm happy to see the GitHub action working fine. 😄 |
If "Every two weeks on Wednesday" means 2nd and 4th week, it looks good to me :). |
@Eeap Unfortuntely, not necessarily. It just means in a 2-week cadence, it could be 1st and 3rd. What would be the correct translation for that? |
Then "2주마다" is ok, but it is not natural with following words ("2주마다 수요일" is not natural). So"격주" instead of "2주마다" is better to understand for Korean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
We changed the cadence of the meeting, this has not been updated on the website yet.
I made an effort to translate to Chinese, Japanese and Korean with the help of Google translate and my very limited understanding of these languages. Would appreciate a review by fluent speakers 🙏 @node @hhiroshell @Eeap