Skip to content

regex: deprecate engine type #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

regex: deprecate engine type #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f34eb5
regex: deprecate engine type
zhxie Jun 23, 2022
e01a42f
go: sync generated files
zhxie Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions go/xds/type/matcher/v3/regex.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions go/xds/type/matcher/v3/regex.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions xds/type/matcher/v3/regex.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,8 @@ message RegexMatcher {
message GoogleRE2 {}

oneof engine_type {
option (validate.required) = true;

// Google's RE2 regex engine.
GoogleRE2 google_re2 = 1 [ (validate.rules).message = {required : true} ];
GoogleRE2 google_re2 = 1 [ deprecated = true, (validate.rules).message = {required : true} ];
}

// The regex match string. The string must be supported by the configured
Expand Down