Move DisabledSensors_RBV to module template - #36
Open
henriquesimoes wants to merge 2 commits into
Open
Conversation
ericonr
approved these changes
Jul 14, 2026
All module-specific PVs have a M<n>: component in its name, right after the detector prefix. Rename DisabledSensorsM<n>_RBV to M<n>:DisabledSensors_RBV to follow this pattern here. This will enable us to use the module.template file to properly replicate it based on the number of modules in each detector model.
These PVs are module-based, so they must belong to the module.template file, which makes them properly replicated for all the detector modules by the model substitution files. Move it there. Fixes: 8e92516 (Move module-specific records to dedicated template, 2025-02-27)
henriquesimoes
force-pushed
the
disabled-sensors
branch
from
July 24, 2026 21:09
636bbe3 to
47a4c1e
Compare
Collaborator
Author
|
After further discussion about these PVs, it become clear their names aren't good. Those aren't actually disabled sensors but rather "unresponsive chips". Thus, it is valuable to take the opportunity to rename them to a better name instead. Maybe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These PVs are module-based, so they must belong to the module.template
file, which makes them properly replicated for all the detector modules
by the model substitution files. Move it there.
Fixes: 8e92516 (Move module-specific records to dedicated template, 2025-02-27)
This is a leftover from #24.