Fix stack corruption in dacCountScan. - #9
Open
ericonr wants to merge 1 commit into
Open
Conversation
While the dac enum is likely to be already the size and alignment of an int, that was definitely not the case for current_module, since it is an uint8_t. That meant the call to getParameter with the "int *" pointer cast, a case of pointer misuse, was causing stack memory corruption, and could also lead to unaligned access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the dac enum is likely to be already the size and alignment of an int, that was definitely not the case for current_module, since it is an uint8_t. That meant the call to getParameter with the "int *" pointer cast, a case of pointer misuse, was causing stack memory corruption, and could also lead to unaligned access.