Logical variable - #1
Open
gustavosr8 wants to merge 15 commits into
Open
Conversation
Author
|
Same for #2 |
gustavosr8
commented
Jun 25, 2026
gustavosr8
left a comment
gustavosr8
left a comment
Author
There was a problem hiding this comment.
Message suggestion for ccfdc3a:
Add SpecsLab Prodigy Remote Control Protocol manual version 1.19
About the second commit, it is very hard to read. Please, if possible, split it into minor ones, explaining in detail what is being done.
Version 1.19 from July 11, 2022
Basic formatting style to standardize formatting across files and fix broken formatting in some files.
Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
A delay was introduced to ensure that the data will be ready to read out. This don't seems to be needed anymore. The DATA_DELAY_MAX PV was introduced in 884ce9b to make it easier to test different values of delays, so it can also be removed. Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
image and spectrum are defined as epicsFloat64 pointers, so it should also be the type casting. Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
If the status is set to asynError during the acquisition for any reason, stop it and send a clear command. Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
gustavosr8
force-pushed
the
logical_variable
branch
from
August 25, 2026 12:49
4b71a61 to
e10e26d
Compare
Author
|
@guirodrigueslima I've split the commits in some related changes and improved a little bit the documentation. Its still very superficial, evenly in the last commit, but please check if everything still working as expected and if all commits makes sense. Also, feel free to rework any of this, if you want. |
gustavosr8
force-pushed
the
logical_variable
branch
from
August 25, 2026 19:36
e10e26d to
9b0ec69
Compare
gustavosr8
force-pushed
the
logical_variable
branch
from
August 26, 2026 12:19
9b0ec69 to
5186b09
Compare
Besides the parameter type, the function can be reworked to also return the unit, if present in the data. Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
This seems necessary only for a specific CCD scenario found in DLS. Removing it since the problem seems not reproducible in other facilities. Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
The Start/End and Scan variable PVs are missing to fulfill the DefineSpectrumVLS [1] command, that will be implemented in the future. [1] SpecsLab Prodigy TCP Remote Protocol 1.19, section 2.7 Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
Define a parsing for reading it from the received command and send it with the corresponding value unit when sending a command. Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
When using the logical variable mode, we have a frame being captured for each logical step. For this reason, now we are dealing with a 3-dimensional data. The logic for finishing one acquisition has also being simplified. The NDArray allocation has being moved to the end of the loop, when the frame callback is actually being called. Co-authored-by: Guilherme Rodrigues de Lima <guilherme.lima@lnls.br>
gustavosr8
force-pushed
the
logical_variable
branch
from
August 27, 2026 11:26
5186b09 to
5b46994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @guirodrigueslima @henriquesimoes @ericonr!
I've noticed we had this PR staled in the upstream, so I thought it would be better if we go through an internal cycle of reviews and then bring this to AD collab meeting. For this reason, I'm opening this internal PR and assigning it to @guirodrigueslima