Skip to content

chore: fix auto release workflow config#59

Merged
fengmk2 merged 4 commits intomasterfrom
fix-auto-releases
Oct 23, 2025
Merged

chore: fix auto release workflow config#59
fengmk2 merged 4 commits intomasterfrom
fix-auto-releases

Conversation

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Oct 23, 2025

[skip ci]

Summary by CodeRabbit

  • New Features

    • Added Node.js 24 to the test matrix and enabled grouped merge handling in CI.
  • Documentation

    • Expanded Mirrors section with Website, JSON and CDN entries.
    • Simplified contributor area to a badge.
  • Chores

    • Switched linting toolchain and removed the project ESLint configuration.
    • Updated CI to include a lint job and tightened workflow permissions.
  • Tests

    • Tests updated to use Node's built-in test runner and test script adjusted.

@fengmk2 fengmk2 requested a review from Copilot October 23, 2025 03:52
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Warning

Rate limit exceeded

@fengmk2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 16023cc and 5858f43.

📒 Files selected for processing (3)
  • .github/workflows/nodejs.yml (1 hunks)
  • lib/mirror_config.js (3 hunks)
  • package.json (1 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

The project migrates from ESLint to Oxlint for linting, removes the project ESLint config, updates package scripts and devDependencies, adds Node 24 and a lint job to GitHub Actions, adjusts release workflow permissions, and simplifies README mirrors and contributor badge.

Changes

Cohort / File(s) Change Summary
Linting config removed
\.eslintrc
Deleted project ESLint configuration file that extended eslint-config-egg.
Package scripts & devDependencies
package\.json
Replaced lint script to use oxlint; updated test and ci scripts to use node --test; removed egg-bin, eslint, eslint-config-egg, and git-contributor; added oxlint@^1.24.0; removed contributor script.
Tests
test/index\.test\.js
Added Node's node:test API import: const { describe, it, before, after, beforeEach, afterEach } = require('node:test');.
CI workflows
.github/workflows/nodejs\.yml, .github/workflows/release\.yml
Node CI: added merge_group trigger and updated Node matrix to include 24; added a lint job (uses Node 22). Release workflow: added explicit permissions (contents, deployments, issues, pull-requests, id-token) and removed NPM_TOKEN secret injection (keeps GIT_TOKEN).
Documentation
README\.md
Mirrors section split into Web Site, JSON endpoint, and CDN endpoint prefix; removed dense contributor table and GITCONTRIBUTOR markers, replaced with a single contributor badge image link.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 With oxlint now leading the way,
ESLint's config hopped out today,
CI learns Node twenty-four,
Release perms tidy, README more,
I thump my foot — clean code hooray!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: fix auto release workflow config" accurately refers to a real component of this changeset—specifically the modifications made to .github/workflows/release.yml, which added permissions and adjusted secret handling. However, the PR includes many other substantial changes beyond the release workflow, including migration from ESLint to oxlint, switching from egg-bin to node --test for testing, updating Node.js versions in CI, removing multiple dependencies, and updating the README. The title captures only one aspect of these changes rather than the primary scope of the refactoring effort.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link

Summary of Changes

Hello @fengmk2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the project's development workflow by transitioning its code linting from ESLint to OXLint, which often brings performance benefits. Concurrently, it refines the project's documentation by updating mirror endpoint details and modernizing the display of project contributors in the README.md file.

Highlights

  • Linting Tool Migration: The project has migrated its linting infrastructure from ESLint to OXLint, involving the removal of .eslintrc and updates to package.json scripts and dev dependencies.
  • README.md Updates: The README.md file has been updated to provide more precise descriptions for mirror endpoints and to replace the manually maintained contributor list with an automatically generated badge from contrib.rocks.
  • Dependency Cleanup: The git-contributor script and its corresponding dependency, along with ESLint and eslint-config-egg, have been removed from package.json.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/nodejs.yml
    • .github/workflows/release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project's tooling and configuration by migrating from ESLint to oxlint for linting, simplifying the auto-release workflow configuration, and updating documentation. The changes streamline dependencies and modernize the CI/CD setup.

Key changes:

  • Migration from ESLint to oxlint for faster linting
  • Simplified GitHub Actions release workflow with explicit permissions and removal of NPM_TOKEN
  • Updated contributor documentation to use contrib.rocks service

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Replaced eslint/eslint-config-egg with oxlint, removed git-contributor script
.github/workflows/release.yml Added explicit permissions, removed NPM_TOKEN secret
.github/workflows/nodejs.yml Added Node.js 24 to test matrix
README.md Updated mirrors documentation and replaced git-contributor section with contrib.rocks badge
.eslintrc Removed ESLint configuration file
test/index.test.js Added blank line for formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@socket-security
Copy link

socket-security bot commented Oct 23, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedoxlint@​1.24.0941008896100

View full report

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the auto-release workflow configuration by removing the eslint configuration, updating the mirrors in the README, and updating dependencies in the package.json to use oxlint. The contributor section in README.md was replaced with an image linking to contributors.

@fengmk2 fengmk2 merged commit 745a3a3 into master Oct 23, 2025
10 checks passed
@fengmk2 fengmk2 deleted the fix-auto-releases branch October 23, 2025 04:22
fengmk2 pushed a commit that referenced this pull request Oct 23, 2025
[skip ci]

## 2.18.0 (2025-10-23)

* chore: fix auto release workflow config (#59) ([745a3a3](745a3a3)), closes [#59](#59)
* chore: use npm-release.yml ([0a631e8](0a631e8))
* feat: add binary mirror support for @lvce-editor/ripgrep package (#58) ([918ab03](918ab03)), closes [#58](#58) [#57](#57) [#57](#57)
@github-actions
Copy link

🎉 This PR is included in version 2.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants