-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(elk): add missing version field #760
Conversation
此字段在刚开始接入 es 时就已经存在(PR: cnpm#513). 因为 es 中设置了 `dynamic: true` 故一直没有报错,但为了更好的健壮性, 对其进行补全. 不影响现有索引, 无需 `reindex`, 但如果企业是刚开始接入 cnpm, 那设置下会更好. Signed-off-by: Kevin Cui <[email protected]>
WalkthroughThe changes update the Elasticsearch index mapping for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/elasticsearch-setup.md (1)
940-947
: Ensure Consistency in Mapping ExamplesIn the earlier mapping snippet (lines 603–606) the
"version"
field is added under thepackage
properties. However, in the second mapping example (the Kibana dev tool section), the new"version"
field is missing. For clarity and to avoid potential confusion for new integrations, please update the second mapping snippet to include the"version"
field. For example, after the"scope"
field and before the"versions"
field, you might add:"scope": { "normalizer": "raw", "type": "keyword" }, +"version": { + "normalizer": "raw", + "type": "keyword" +}, "versions": { "index": false, "type": "text" }This will make both mapping examples consistent and reinforce the intended schema update.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/elasticsearch-setup.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: test-postgresql-fs-nfs (22, ubuntu-latest)
- GitHub Check: test-mysql57-fs-nfs (22, ubuntu-latest)
- GitHub Check: test-postgresql-fs-nfs (20, ubuntu-latest)
- GitHub Check: test-mysql57-fs-nfs (20, ubuntu-latest)
- GitHub Check: test-postgresql-fs-nfs (18, ubuntu-latest)
- GitHub Check: test-mysql57-fs-nfs (18, ubuntu-latest)
- GitHub Check: test-postgresql-fs-nfs (18.20.0, ubuntu-latest)
- GitHub Check: Analyze (typescript)
- GitHub Check: Analyze (javascript)
- GitHub Check: test-mysql57-fs-nfs (18.20.0, ubuntu-latest)
🔇 Additional comments (1)
docs/elasticsearch-setup.md (1)
603-606
: New "version" Field Defined CorrectlyThe addition of the
"version"
field is implemented as intended, with anormalizer
set to"raw"
and thetype
defined as"keyword"
. This ensures that package version strings are stored exactly for efficient exact-match queries.
@Beace 看看,没问题就合并了。 |
LGTM. 这个没问题的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
此字段在刚开始接入 es 时就已经存在(PR: #513). 因为 es 中设置了
dynamic: true
故一直没有报错, 但为了更好的健壮性, 对其进行补全.不影响现有索引, 无需
reindex
, 但如果企业是刚开始接入 cnpm, 那设置下会更好.PTAL @Beace @fengmk2
Summary by CodeRabbit