refactor: use tegg v4 #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
PR Overview
This PR refactors the codebase to support tegg v4 by updating import paths to include explicit “.js” extensions where needed. The changes ensure compatibility with the new module resolution behavior in tegg v4.
- Updated import statements in various files to append “.js”
- Adjusted dynamic import usage in app.ts for ChangesStreamService
- Ensured consistency of import formats across binary adapter modules
Reviewed Changes
| File | Description |
|---|---|
| app/common/adapter/NPMRegistry.ts | Updated import paths to include “.js” extension |
| app/common/adapter/binary/NodeBinary.ts | Added “.js” extensions to imports |
| app/common/adapter/binary/AbstractBinary.ts | Added “.js” extensions to imports |
| app/common/PackageUtil.ts | Updated import path for PackageRepository |
| app/common/adapter/binary/ChromeForTestingBinary.ts | Added “.js” extensions in import statements |
| app/common/adapter/binary/GithubBinary.ts | Updated import paths for BinaryType and related items |
| app/common/adapter/binary/ImageminBinary.ts | Updated import paths to include “.js” extension |
| app/common/adapter/NFSAdapter.ts | Added “.js” extensions to imported modules |
| app/common/adapter/binary/PrismaBinary.ts | Updated imports with the “.js” extension |
| app/common/adapter/binary/NwjsBinary.ts | Added “.js” extensions to import statements |
| app/common/adapter/binary/ElectronBinary.ts | Updated import paths with “.js” extension |
| app/common/adapter/binary/CypressBinary.ts | Added “.js” extensions to imports |
| app/common/adapter/binary/BucketBinary.ts | Updated import ordering and added “.js” extensions |
| app/common/adapter/BugVersionStore.ts | Updated import for BugVersion with “.js” extension |
| app.ts | Changed import of Application and adjusted lifecycle |
| app/common/adapter/binary/NodePreGypBinary.ts | Updated import paths with “.js” extension |
| app/common/adapter/binary/PlaywrightBinary.ts | Added “.js” extensions in import statements |
| app/common/adapter/binary/ApiBinary.ts | Updated import paths with “.js” for consistency |
| app/common/adapter/binary/EdgedriverBinary.ts | Added “.js” extension to import statements |
| app/common/FileUtil.ts | Updated import of dayjs to include “.js” extension |
Copilot reviewed 289 out of 289 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
app.ts:5
- Consider removing the commented-out import for ChangesStreamService if it is no longer needed, to reduce confusion and keep the code clean.
// import { ChangesStreamService } from './app/core/service/ChangesStreamService.js';
fengmk2
commented
Mar 2, 2025
fengmk2
commented
Mar 4, 2025
| @@ -144,7 +145,8 @@ describe('test/core/service/RegistryManagerService/index.test.ts', () => { | |||
| await registryManagerService.createSyncChangesStream({ registryId: registry.registryId, since: '100' }); | |||
| const targetName = 'CUSTOM_WORKER'; | |||
| const task = await taskRepository.findTaskByTargetName(targetName, TaskType.ChangesStream); | |||
| assert((task?.data as ChangesStreamTaskData).since === ''); | |||
| assert(task); | |||
| assert.equal((task.data as ChangesStreamTaskData).since, '100'); | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #765 +/- ##
==========================================
- Coverage 96.54% 96.54% -0.01%
==========================================
Files 191 192 +1
Lines 19251 19365 +114
Branches 2517 1816 -701
==========================================
+ Hits 18586 18696 +110
- Misses 665 669 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.