Skip to content

feat: add @temporalio to allowLargePackages#522

Merged
fengmk2 merged 1 commit intocnpm:masterfrom
hello-astar:feat/add-large-scopes-temporalio
Mar 19, 2026
Merged

feat: add @temporalio to allowLargePackages#522
fengmk2 merged 1 commit intocnpm:masterfrom
hello-astar:feat/add-large-scopes-temporalio

Conversation

@hello-astar
Copy link
Contributor

@hello-astar hello-astar commented Mar 19, 2026

添加白名单申请

请在提交此 Pull Request 之前,确认您已满足以下所有条件:

✅ 必须确认的条件

  • 遵循添加说明:我已经按照 README.md 中的说明正确添加了白名单条目
  • 非 GKD 订阅规则:我添加的包 不是 GKD 广告屏蔽订阅规则相关的包(包含 gkdgkd-subscriptiongkd_subscription 等关键词的包将被直接关闭)
  • 包类型和使用情况:我添加的 package 是 library(而不是 application),并且有真实的公网用户正在依赖使用。我们不接受为刚创建且没有真实下载流量的 package 添加白名单
  • Scope 要求(如果申请添加 scope):申请添加的 scope 必须已包含热门包(如周下载量超过 1 万)。我们不接受为刚创建且无热门包的 scope 添加白名单

📝 请提供以下信息

添加的包/scope 名称:
@temporalio

添加原因:

  • @temporalio/core-bridge 是 Temporal TypeScript SDK 的核心底层 bridge 包,负责 Node.js 与 Rust 实现的 Temporal Core 之间的通信。该包包含预编译的平台原生二进制文件(.node 文件),通过 unpkg 可方便用户在浏览器/CDN 环境中访问其类型声明和 JS 文件,也便于 CI/CD 环境快速获取对应平台的预编译产物。
  • 由于@temporalio/core-bridge属于https://github.com/temporalio scope下的一个包,这里直接添加scope
  • 包体积过大,需要添加large scope

使用情况说明(如周下载量、依赖该包的项目等):

  • 周下载量:约 861,600 次(数据来源:npmjs.com)
  • 该包是 @temporalio/worker 的核心依赖,而 @temporalio/worker 被大量后端 Node.js 项目使用
  • 由 Temporal Technologies Inc. 官方维护,稳定发布超过 4 年(首次发布 2021 年 6 月)

📋 其他确认

  • 我已使用 CLI 工具添加(推荐),或已确保手动修改的 package.json 格式正确
  • 我理解此 PR 合并后会在 5 分钟内全网生效

感谢您为 unpkg 白名单做出贡献!🎉

Summary by CodeRabbit

  • Chores
    • Updated dependencies configuration to support additional scoped packages.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在通过将 @temporalio scope 列入白名单,增强 unpkg 服务处理大型包的能力。这一添加对于支持 @temporalio/core-bridge 的分发至关重要,该包是 Temporal TypeScript SDK 的关键组件,包含预编译的原生二进制文件,并具有显著的下载量。通过包含此 scope,用户可以更方便地通过 unpkg 和 CDN 环境访问类型声明、JS 文件和预编译的产物。

Highlights

  • 新增白名单: 将 @temporalio scope 添加到 allowLargePackages 白名单中,以支持其核心依赖包 @temporalio/core-bridge 的分发。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

📝 Walkthrough

Walkthrough

This PR adds @temporalio to the allowLargeScopes array in package.json, extending the whitelist of scoped packages permitted to use large scope behavior.

Changes

Cohort / File(s) Summary
Configuration Update
package.json
Added @temporalio scope to the allowLargeScopes array.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

released

Suggested reviewers

  • fengmk2

Poem

🐰 A scope hops into the list so fine,
Temporal magic joins the line,
Large bundles welcomed, permission granted,
One line added, cleanly chanted,
The whitelist grows, hop by hop! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'allowLargePackages' but the actual change adds '@temporalio' to the 'allowLargeScopes' array, not 'allowLargePackages'. This is a factual inaccuracy. Update the PR title to 'feat: add @temporalio to allowLargeScopes' to accurately reflect the configuration property being modified.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The PR description follows the required template structure with all mandatory sections completed, checkboxes checked, and detailed information provided about the package, usage metrics, and rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds "@temporalio" to the allowLargeScopes array in package.json. This change allows packages under the @temporalio scope to bypass size restrictions on unpkg. I have added a review comment to address a potential issue.

@fengmk2 fengmk2 enabled auto-merge March 19, 2026 02:26
@fengmk2 fengmk2 changed the title feat: add @temporalio to allowLargePackages feat: add '@temporalio' to allowLargePackages Mar 19, 2026
@fengmk2 fengmk2 changed the title feat: add '@temporalio' to allowLargePackages feat: add @temporalio to allowLargePackages Mar 19, 2026
@fengmk2 fengmk2 added this pull request to the merge queue Mar 19, 2026
Merged via the queue into cnpm:master with commit b313e88 Mar 19, 2026
13 checks passed
fengmk2 pushed a commit that referenced this pull request Mar 19, 2026
[skip ci]

## 1.269.0 (2026-03-19)

* feat: add `@temporalio` to allowLargePackages (#522) ([b313e88](b313e88)), closes [#522](#522)
@github-actions
Copy link

🎉 This PR is included in version 1.269.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants