Keep missing texture names, plus added flag in Set Texture for texture substitution.#1629
Merged
alemuntoni merged 4 commits intocnr-isti-vclab:develfrom Dec 18, 2025
Merged
Keep missing texture names, plus added flag in Set Texture for texture substitution.#1629alemuntoni merged 4 commits intocnr-isti-vclab:develfrom
alemuntoni merged 4 commits intocnr-isti-vclab:develfrom
Conversation
…tuting an existing texture.
Member
|
Thanks for the PR! |
Member
|
Thanks @Sallo97! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same pull-request proposed in #1627 and #1628 , only on the
develbranch.Avoid deleting original texture names when loading
When loading a mesh, if meshlab was not able to find the associated texture files, it uses a dummy texture instead, named
dummy.png. However, in doing so it also removes any mention to the absent texture(s). I modified the loading mesh process insrc/common/ml_document/mesh_model.cppto keep its missing texture name(s) list by commenting line 124 insrc/common/ml_document/mesh_model.cpp:// textName = "dummy.png";Adding possibility of not erasing all the names in the Set Texture
When setting a new texture to a loaded mesh with the filter
Set Texture, it clears all information regarding previous associated ones. This can be frustrating when meshlab loaded a mesh with missing texture, for which the user wants to manually load them up.My solution consists in adding the boolean parameter
updateExistingTexturetofilter_textures.t., each time a texture is loaded and the flag activated, then the filter does not clear any previously loaded mesh and instead if a texture with the same name of the new loaded file exists, its content is substitued with the one provided by the user.