fix: use actual fund codes from DB instead of hardcoded values

Author: chrisns

cloudformation/scenarios/localgov-ims/docker/seed-data.sql

@@ -29,57 +29,63 @@ WHERE f.Disabled = 0
   AND NOT EXISTS (SELECT 1 FROM FundMetadata fm WHERE fm.FundCode = f.FundCode AND fm.MetadataKeyId = @govPayKeyId);
 PRINT '  GOV.UK Pay API keys set'
 
--- 2. Account holders (simple INSERT, no CTEs)
+-- 2. Account holders -- use actual fund codes from the database
 PRINT '=== Seeding account holders ==='
 
 DECLARE @sysUser INT = 0;
 DECLARE @now DATETIME = GETDATE();
 
-IF NOT EXISTS (SELECT 1 FROM AccountHolders WHERE AccountReference = 'CT000001')
+-- Get the first fund code that exists in the database
+DECLARE @firstFund VARCHAR(5);
+SELECT TOP 1 @firstFund = FundCode FROM Funds WHERE Disabled = 0 ORDER BY FundCode;
+PRINT '  Using fund code: ' + ISNULL(@firstFund, 'NONE');
+
+IF @firstFund IS NOT NULL AND NOT EXISTS (SELECT 1 FROM AccountHolders WHERE AccountReference LIKE 'AH%')
+BEGIN
+    DECLARE @j INT = 1;
+    DECLARE @names TABLE (Idx INT IDENTITY, Title VARCHAR(10), Forename VARCHAR(50), Surname VARCHAR(50), Addr1 VARCHAR(60), Postcode VARCHAR(10));
+    INSERT INTO @names VALUES
+    ('Mr','James','Thompson','12 High Street','OX1 1AA'),('Mrs','Sarah','Williams','34 Church Lane','CT1 2BB'),
+    ('Ms','Emma','Johnson','56 Oak Road','GU1 3CC'),('Mr','David','Brown','78 Mill Lane','SO1 4DD'),
+    ('Mrs','Lisa','Davies','90 Station Road','CM1 5EE'),('Mr','Robert','Wilson','11 Park Avenue','RG1 6FF'),
+    ('Ms','Helen','Taylor','23 King Street','EX1 7GG'),('Mr','Michael','Anderson','45 Queens Road','NR1 8HH'),
+    ('Mrs','Claire','Thomas','67 Bridge Street','IP1 9JJ'),('Mr','Andrew','Jackson','89 Market Place','DT1 1KK'),
+    ('Ms','Rachel','White','10 Victoria Road','SN1 2LL'),('Mr','Peter','Harris','22 Albert Street','BA1 3MM'),
+    ('Mrs','Karen','Martin','44 George Lane','SY1 4NN'),('Mr','Steven','Clark','66 William Road','NG1 5PP'),
+    ('Ms','Angela','Lewis','88 Elizabeth Way','LE1 6QQ'),('Mr','Mark','Walker','15 Edward Close','CV1 7RR'),
+    ('Mrs','Julie','Hall','27 Charles Ave','GL1 8SS'),('Mr','Paul','Allen','39 Henry Lane','ST1 9TT'),
+    ('Ms','Nicola','Young','51 Mary Street','CB1 1UU'),('Mr','Simon','King','63 Anne Road','LN1 2VV');
+
+    DECLARE @nCount INT;
+    SELECT @nCount = COUNT(*) FROM @names;
+
+    -- Create account holders using actual fund codes from the database
+    DECLARE @funds TABLE (Idx INT IDENTITY, FundCode VARCHAR(5));
+    INSERT INTO @funds (FundCode) SELECT TOP 10 FundCode FROM Funds WHERE Disabled = 0 ORDER BY FundCode;
+    DECLARE @fTotal INT;
+    SELECT @fTotal = COUNT(*) FROM @funds;
+
+    WHILE @j <= 40
+    BEGIN
+        DECLARE @ref VARCHAR(30) = 'AH' + RIGHT('000000' + CAST(@j AS VARCHAR), 6);
+        DECLARE @fIdx INT = (@j % @fTotal) + 1;
+        DECLARE @nIdx INT = (@j % @nCount) + 1;
+        DECLARE @fund VARCHAR(5);
+        SELECT @fund = FundCode FROM @funds WHERE Idx = @fIdx;
+
+        DECLARE @t VARCHAR(10), @fn VARCHAR(50), @sn VARCHAR(50), @a1 VARCHAR(60), @pc VARCHAR(10);
+        SELECT @t=Title, @fn=Forename, @sn=Surname, @a1=Addr1, @pc=Postcode FROM @names WHERE Idx = @nIdx;
+
+        INSERT INTO AccountHolders (AccountReference, FundCode, Title, Forename, Surname, AddressLine1, Postcode, CurrentBalance, PeriodDebit, PeriodCredit, RecordType, CreatedAt, CreatedByUserId)
+        VALUES (@ref, @fund, @t, @fn, @sn, @a1, @pc, CAST(100 + (@j * 37 % 1700) AS DECIMAL(18,2)), 0, 0, 'D', @now, @sysUser);
+
+        SET @j = @j + 1;
+    END
+    PRINT '  Inserted 40 account holders'
+END
+ELSE IF @firstFund IS NULL
 BEGIN
-    INSERT INTO AccountHolders (AccountReference, FundCode, Title, Forename, Surname, AddressLine1, AddressLine2, AddressLine3, Postcode, CurrentBalance, PeriodDebit, PeriodCredit, RecordType, CreatedAt, CreatedByUserId) VALUES
-    ('CT000001','01','Mr','James','Thompson','12 High Street','','Anytown','OX1 1AA',1250.00,0,0,'D',@now,@sysUser),
-    ('CT000002','01','Mrs','Sarah','Williams','34 Church Lane','Flat 2','Riverdale','CT1 2BB',875.50,0,0,'D',@now,@sysUser),
-    ('CT000003','01','Ms','Emma','Johnson','56 Oak Road','','Hillview','GU1 3CC',1680.00,0,0,'D',@now,@sysUser),
-    ('CT000004','01','Mr','David','Brown','78 Mill Lane','Unit 4','Lakeside','SO1 4DD',450.25,0,0,'D',@now,@sysUser),
-    ('CT000005','01','Mrs','Lisa','Davies','90 Station Road','','Greenfield','CM1 5EE',1100.00,0,0,'D',@now,@sysUser),
-    ('CT000006','01','Mr','Robert','Wilson','11 Park Avenue','Apt 3','Woodlands','RG1 6FF',925.75,0,0,'D',@now,@sysUser),
-    ('CT000007','01','Ms','Helen','Taylor','23 King Street','','Meadowbank','EX1 7GG',1450.00,0,0,'D',@now,@sysUser),
-    ('CT000008','01','Mr','Michael','Anderson','45 Queens Road','Floor 2','Fairview','NR1 8HH',780.00,0,0,'D',@now,@sysUser),
-    ('CT000009','01','Mrs','Claire','Thomas','67 Bridge Street','','Westfield','IP1 9JJ',1320.50,0,0,'D',@now,@sysUser),
-    ('CT000010','01','Mr','Andrew','Jackson','89 Market Place','Suite 1','Eastgate','DT1 1KK',560.00,0,0,'D',@now,@sysUser),
-    ('CT000011','01','Ms','Rachel','White','10 Victoria Road','','Northway','SN1 2LL',1750.00,0,0,'D',@now,@sysUser),
-    ('CT000012','01','Mr','Peter','Harris','22 Albert Street','Flat 5','Southend','BA1 3MM',890.25,0,0,'D',@now,@sysUser),
-    ('CT000013','01','Mrs','Karen','Martin','44 George Lane','','Oldtown','SY1 4NN',1100.50,0,0,'D',@now,@sysUser),
-    ('CT000014','01','Mr','Steven','Clark','66 William Road','Block B','Newbury','NG1 5PP',675.00,0,0,'D',@now,@sysUser),
-    ('CT000015','01','Ms','Angela','Lewis','88 Elizabeth Way','','Crossroads','LE1 6QQ',1500.00,0,0,'D',@now,@sysUser),
-    ('CT000016','01','Mr','Mark','Walker','15 Edward Close','Flat 1','Springvale','CV1 7RR',430.75,0,0,'D',@now,@sysUser),
-    ('CT000017','01','Mrs','Julie','Hall','27 Charles Ave','','Riverside','GL1 8SS',1200.00,0,0,'D',@now,@sysUser),
-    ('CT000018','01','Mr','Paul','Allen','39 Henry Lane','Unit 7','Bayview','ST1 9TT',965.50,0,0,'D',@now,@sysUser),
-    ('CT000019','01','Ms','Nicola','Young','51 Mary Street','','Clearwater','CB1 1UU',1380.00,0,0,'D',@now,@sysUser),
-    ('CT000020','01','Mr','Simon','King','63 Anne Road','Flat 9','Stonegate','LN1 2VV',720.25,0,0,'D',@now,@sysUser);
-    -- Business Rates
-    INSERT INTO AccountHolders (AccountReference, FundCode, Title, Forename, Surname, AddressLine1, AddressLine2, AddressLine3, Postcode, CurrentBalance, PeriodDebit, PeriodCredit, RecordType, CreatedAt, CreatedByUserId) VALUES
-    ('BR000001','02','Mr','Richard','Evans','1 Commerce Way','','Business Park','BS1 1AA',4500.00,0,0,'D',@now,@sysUser),
-    ('BR000002','02','Mrs','Patricia','Roberts','2 Trade Street','Unit 12','Industrial Estate','LS1 2BB',3200.00,0,0,'D',@now,@sysUser),
-    ('BR000003','02','Mr','Christopher','Turner','3 Enterprise Road','','Retail Park','M1 3CC',8750.00,0,0,'D',@now,@sysUser),
-    ('BR000004','02','Ms','Margaret','Phillips','4 Market Way','Floor 3','Town Centre','L1 4DD',2100.00,0,0,'D',@now,@sysUser),
-    ('BR000005','02','Mr','Thomas','Campbell','5 Factory Lane','','Industrial Zone','S1 5EE',5600.00,0,0,'D',@now,@sysUser);
-    -- Housing Rents
-    INSERT INTO AccountHolders (AccountReference, FundCode, Title, Forename, Surname, AddressLine1, AddressLine2, AddressLine3, Postcode, CurrentBalance, PeriodDebit, PeriodCredit, RecordType, CreatedAt, CreatedByUserId) VALUES
-    ('HR000001','03','Mr','William','Scott','1 Council Estate','','Oakfield','B1 1AA',520.00,0,0,'D',@now,@sysUser),
-    ('HR000002','03','Mrs','Dorothy','Green','2 Tower Block','Flat 14','Riverside','E1 2BB',480.50,0,0,'D',@now,@sysUser),
-    ('HR000003','03','Mr','George','Baker','3 Sheltered Close','','Hillside','N1 3CC',395.00,0,0,'D',@now,@sysUser),
-    ('HR000004','03','Ms','Susan','Adams','4 Maisonette Row','Ground Floor','Lakewood','W1 4DD',610.00,0,0,'D',@now,@sysUser),
-    ('HR000005','03','Mr','Edward','Nelson','5 Terrace Walk','','Meadows','SE1 5EE',445.75,0,0,'D',@now,@sysUser);
-    -- Parking
-    INSERT INTO AccountHolders (AccountReference, FundCode, Title, Forename, Surname, AddressLine1, AddressLine2, AddressLine3, Postcode, CurrentBalance, PeriodDebit, PeriodCredit, RecordType, CreatedAt, CreatedByUserId) VALUES
-    ('PK000001','04','Mr','Daniel','Mitchell','10 Elm Street','','Parkside','SW1 1AA',35.00,0,0,'D',@now,@sysUser),
-    ('PK000002','04','Ms','Jennifer','Carter','20 Birch Lane','','Woodside','WC1 2BB',70.00,0,0,'D',@now,@sysUser),
-    ('PK000003','04','Mr','Matthew','Morris','30 Pine Avenue','','Hillcrest','EC1 3CC',35.00,0,0,'D',@now,@sysUser),
-    ('PK000004','04','Mrs','Laura','Rogers','40 Cedar Close','','Valleyview','NW1 4DD',105.00,0,0,'D',@now,@sysUser),
-    ('PK000005','04','Mr','Joseph','Reed','50 Willow Way','','Brookside','N1 5EE',70.00,0,0,'D',@now,@sysUser);
-    PRINT '  Inserted 35 account holders'
+    PRINT '  WARNING: No funds found in database, skipping account holders'
 END
 ELSE
 BEGIN
@@ -116,9 +122,11 @@ BEGIN
             LOWER(NEWID()), LOWER(NEWID()), 'S',
             DATEADD(MINUTE, -@i * 250, GETDATE()),
             DATEADD(MINUTE, -@i * 250, GETDATE()),
-            'CT000001', 1, @fc, @mc,
+            ISNULL((SELECT TOP 1 AccountReference FROM AccountHolders WHERE FundCode = @fc), 'AH000001'),
+            1, @fc, @mc,
             CAST(10 + (@i * 7 % 190) AS DECIMAL(18,2)),
-            0, 'E0', 'Payment received', 0, 0);
+            0, ISNULL((SELECT TOP 1 VatCode FROM Vat WHERE Disabled = 0), 'E0'),
+            'Payment received', 0, 0);
 
         SET @i = @i + 1;
     END