Bump cookie and @lhci/cli#1
Merged
Merged
Conversation
dependabot
Bot
added
dependencies
Member
|
@dependabot rebase |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/multi-95b17ac0ae
branch
from
b4ea7d4 to
1a991f8
Compare
Bumps [cookie](https://github.com/jshttp/cookie) to 0.7.1 and updates ancestor dependency [@lhci/cli](https://github.com/GoogleChrome/lighthouse-ci). These dependencies need to be updated together. Updates `cookie` from 0.4.2 to 0.7.1 - [Release notes](https://github.com/jshttp/cookie/releases) - [Commits](jshttp/cookie@v0.4.2...v0.7.1) Updates `@lhci/cli` from 0.14.0 to 0.15.1 - [Release notes](https://github.com/GoogleChrome/lighthouse-ci/releases) - [Commits](GoogleChrome/lighthouse-ci@v0.14.0...v0.15.1) --- updated-dependencies: - dependency-name: cookie dependency-version: 0.7.1 dependency-type: indirect - dependency-name: "@lhci/cli" dependency-version: 0.15.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/multi-95b17ac0ae
branch
from
1a991f8 to
106047c
Compare
Member
|
@dependabot rebase |
Contributor
Author
|
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
1 task
chrisns
added a commit
that referenced
this pull request
May 12, 2026
Address review findings against PR #233: 1. Investigated the repository_owner claim properly by shipping a one-shot _oidc-debug.yml workflow (since deleted) that decoded the GitHub Actions OIDC JWT and dumped its claims. CONFIRMED: the token DOES contain `repository_owner: co-cddo`. Re-tested the trust policy with the condition restored using both StringEquals and StringLike. Both fail reproducibly with the same "Not authorized" error. Whatever AWS-side mechanism evaluates the claim against the condition key `token.actions.githubusercontent.com:repository_owner` doesn't match, despite the claim being present in the token. Document in Step 10: the original spec's belt-and-braces is omitted here, the remaining defence chain (sub-pattern lock + GitHub fork isolation + smoke-test-deploy environment branch policy + CODEOWNERS) is documented as net-equivalent, and the door is left open to re-add the condition if a fix is identified later (different key spelling, provider-config tweak, AWS docs update). 2. Config file `expected_scps` comment said "Expected count: 4 (AwsNuke + Restrictions + ProtectISB + LimitRegions)" but the live state has 2 entries (Restrictions + FullAWSAccess) because the fallback branch was taken AND AwsNuke was subsequently detached for OIDC functionality. Rewrite the comment to document the current state, what's NOT attached and why (ProtectISB blocks role creation; AwsNuke blocks sts:*), and guidance for future SCP additions. 3. Config file's "Public-repo disclosure note" listed `trust-policy repository_owner claim` as defence (b). That condition has been removed per finding #1; rewrite the defence chain to match what's actually in place and cross-reference the runbook investigation. 4. Refresh runbook_version SHA to point at the runbook-fix commit (4c0d2ef instead of 11d9676, which was the pre-fix sha) and setup_date to today. The config-vs-runbook drift was the literal bug called out in the adversarial review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps cookie to 0.7.1 and updates ancestor dependency @lhci/cli. These dependencies need to be updated together.
Updates
cookiefrom 0.4.2 to 0.7.1Release notes
Sourced from cookie's releases.
Commits
cf4658f0.7.16a8b8f5Allow leading dot for domain (#174)58015c0Remove more code and perf wins (#172)ab057d60.7.05f02ca8Migrate history to GitHub releasesa5d591cMigrate history to GitHub releases51968f9Skip isNaN9e7ca51perf(parse): cache length, return early (#144)d6f39b0Fix tests for old node6bb701fRemove failing scorecardMaintainer changes
This version was pushed to npm by blakeembrey, a new releaser for cookie since your current version.
Updates
@lhci/clifrom 0.14.0 to 0.15.1Release notes
Sourced from
@lhci/cli's releases.Commits
76a49c7fix: use viewer origin as string instead of object (#1109)602bf7dchore: bump lhci references to 0.15d2cdea9chore: update docker images with latest version6b3b50efeat: upgrade to lighthouse 12.6.1 (#1103)912d985chore: update versions in ci (#1104)e83b2f6fix(cli): improve filename sanitization for hash routes (#1084)d04aba1feat(cli): change wizard default branch to main (#1069)115818achore: Heroku Postgres Hobby plan doesn't exist anymore (#1077)ef83477chore: update versions in heroku-server recipe (#1078)3cac9ebdocs: update GitHub Actions versions in README.md (#1086)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.