fix(ci): round 2 follow-ups to unblock deploy-blueprints synth#189
Merged
Conversation
Round 2 after PR #188. Remaining failures on run 24719438326: - synth-localgov-ims: tsc couldn't find `fs`, `path`, `crypto`, `__dirname` in constructs. Same TypeScript 6 regression as drupal's jest types: no implicit @types/* pickup. Added `"types": ["node"]` to localgov-ims/cdk/tsconfig.json. - synth-localgov-drupal: tsc + 21 of 22 tests now pass. The one failing test (`Stack creates Aurora writer instance`) still asserted `MaxCapacity: 2`, which stopped matching once the CDK source was raised to 8 in PR #186 (for the 33-module first-boot install). Updated assertion to 8. Local verification: - localgov-ims: `npm install && tsc --noEmit` exits 0. - localgov-drupal: `jest` reports 22 passed, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #188. Two remaining failures on the main-branch
deploy-blueprintsrun after #188 merged:Cannot find module 'fs' / 'path' / 'crypto',Cannot find name '__dirname'. Same TypeScript 6 regression as localgov-drupal had: no implicit@types/*resolution. Added"types": ["node"]tolocalgov-ims/cdk/tsconfig.json.Stack creates Aurora writer instance) still assertedMaxCapacity: 2, which stopped matching once the CDK source was raised to 8 in fix(localgov-drupal): stop MariaDB client verifying Aurora TLS cert #186. Updated the assertion.Test plan
localgov-ims/cdk:npm install && tsc --noEmitexits 0 locally.localgov-drupal/cdk:jestreports22 passed, 0 failedlocally.