Skip to content

fix(smoke): hotfix — orphan-stack sweep skipped live nested children #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisns merged 1 commit into from
May 20, 2026
Merged

fix(smoke): hotfix — orphan-stack sweep skipped live nested children #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion scripts/smoke-pre-deploy-state.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,15 @@ cleanup_orphan() {
# previous recovery stacks (all-demo-recovery-*).
sweep_orphan_stacks() {
local orphans orphan
# CRITICAL: filter on ParentId being absent. Stacks whose name starts
# with ${STACK}- but ParentId is set are LIVE nested children of the
# active umbrella, not orphans. Without this filter the sweep happily
# deletes the working umbrella's children when called from a healthy
# CREATE_COMPLETE state (which it is — use_canonical runs sweep before
# checking whether the umbrella is alive).
orphans=$(aws cloudformation list-stacks \
--stack-status-filter CREATE_COMPLETE UPDATE_COMPLETE UPDATE_ROLLBACK_COMPLETE DELETE_FAILED UPDATE_ROLLBACK_FAILED CREATE_FAILED UPDATE_FAILED ROLLBACK_COMPLETE ROLLBACK_FAILED \
--query "StackSummaries[?starts_with(StackName, \`${STACK}-\`)].StackName" \
--query "StackSummaries[?starts_with(StackName, '${STACK}-') && ParentId==\`null\`].StackName" \
--output text 2>/dev/null | tr '\t' '\n' | grep -v '^$' || true)
[ -z "$orphans" ] && { echo "No orphan ${STACK}-* stacks to sweep."; return 0; }
echo "Orphan stacks to sweep:"
Expand Down
Loading