fix(smoke): delete S3 Files mount targets first; tolerate per-item failures#337
Closed
chrisns wants to merge 1 commit into
Closed
fix(smoke): delete S3 Files mount targets first; tolerate per-item failures#337chrisns wants to merge 1 commit into
chrisns wants to merge 1 commit into
Conversation
…ilures
PR 321 retry uncovered two more issues:
1. delete-file-system fails with ConflictException ("has mount targets")
on file systems that still have mount targets attached. Add a
list-mount-targets + delete-mount-target loop before delete-file-system,
plus a 30s grace for the async deletes to complete.
2. delete_bucket_completely returns 1 when all attempts fail (it opens a
stranded-stack issue and gives up). The bare function call inside the
bucket sweep loop is NOT a conditional context, so set -e fires and
kills the whole pre-deploy script. Adding `|| true` to both the
bucket-sweep and orphan-stack-sweep loops keeps them tolerant of
per-item failures; the stranded-stack issues remain the audit trail.
Also captured stderr explicitly (var + echo) for the file-system delete,
matching the pattern used elsewhere — avoids the `cmd | sed` pipefail
trap that killed earlier iterations.
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
Member
Author
|
Superseded — fix commit cherry-picked into PR #321 (renovate/node-26.x) directly so it lands together with the node bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 321 retry surfaced two more pre-deploy bugs:
Fix
Test plan