chore(smoke-nuke): drop ParentId filter so orphaned nested children get swept#352
Merged
Conversation
…et swept After the first nuke, smoke retry for PR #321 failed because all-demo-PaperlessNgx-Q59CODQ417ER and all-demo-BopsPlanning-1KFCREGSEO53T still existed in CFN owning IAM roles, an ALB ('NdxBops-v2-ALB'), an ECS cluster, S3 buckets. The new umbrella's children then collided with "already exists" on every resource. The nuke was filtering on ParentId==null to avoid deleting live nested children, copying the pre-deploy script's safety. But the nuke's whole purpose is the opposite — sweep everything matching ${STACK}- regardless of ownership. Drop the ParentId filter from both the terminal-state and in-progress passes. The pre-deploy script's ParentId filter is still correct there (it must not touch live children), so the two scripts now diverge intentionally on that condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 321 retry after the first nuke failed because
all-demo-PaperlessNgx-Q59CODQ417ERandall-demo-BopsPlanning-1KFCREGSEO53Twere still alive owning IAM roles, an ALB ('NdxBops-v2-ALB'), an ECS cluster, S3 buckets. The new umbrella's children collided withalready existson every resource.The nuke had a
ParentId==nullfilter copied from the pre-deploy script's safety. But the nuke's purpose is the opposite — sweep everything matching${STACK}-regardless of ownership. Dropping the filter from both terminal and in-progress passes.Pre-deploy retains its ParentId filter (must not touch live children); the two scripts diverge intentionally now.