chore(smoke-nuke): parallel stack deletes + 6h timeout#355
Merged
Conversation
Previous nuke runs serialized force_delete_stack per orphan, with each worst-case taking 60+60+30 min between attempts. 9+ orphans × 30-90 min each blows past the 180-min workflow cap; nuke #4 was cancelled mid- delete on the second stuck stack with the umbrella + 9 stacks already gone but two PaperlessNgx/BopsPlanning orphans not yet down. Rewrite PHASE 1 to fire delete-stack on every matching stack simultaneously, then poll all of them in one loop. CFN's per-stack delete is what's slow, not the API; running 16 in parallel is bounded by the slowest single stack rather than the sum. Each iteration also handles DELETE_FAILED inline (retain-retry, then force-retain-everything) so we don't need a separate sequential pass. Bump workflow timeout-minutes 180 → 360 so even worst-case parallel deletes (where every stack hits its 90-min internal cap simultaneously) can complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous nuke serialized deletes; 9+ orphans × 30-90 min each blew past the 180m cap. Rewrite to fire every delete-stack in parallel and poll all in one loop. Bumps timeout to 360m as headroom for worst case.