fix(ci-lease): add s3vectors + capture events on failure#399
Merged
Conversation
…n failure Council-chatbot CFN deploy failed silently because: 1. CIDeployRole missing s3vectors:* permission. Council-chatbot uses AWS::S3Vectors::VectorBucket + AWS::S3Vectors::Index (newer service, separate IAM namespace from s3:*). Without this permission, those resources fail to create, the stack rolls back, and CFN deploy returns a generic 'Failed to create/update the stack'. 2. The Capture CFN events step was skipped because the deploy step set stack_name to GITHUB_OUTPUT AFTER the deploy command — but the command errored before reaching the echo, so the output stayed empty and the gated Capture step never ran. Moved the echo to BEFORE the deploy command so events get captured even on failure. Add s3vectors:* to ScenarioResourceManagement. Future scenarios that use other newer/specialised services will need similar additions.
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Council-chatbot uses AWS::S3Vectors::VectorBucket. Missing s3vectors:* perm. Also fix: capture CFN events ordering so events are captured even when deploy fails.