fix(ci-lease): serialise callers + servicecatalog perm#400
Merged
Conversation
1. Add servicecatalog:* to CIDeployRole. Council-chatbot uses
AWS::ServiceCatalogAppRegistry::Application; without this it fails
with:
AccessDenied: ... is not authorized to perform:
servicecatalog:CreateApplication
Confirmed via the now-captured CFN events on run 26279585440 (which
reached Deploy but rolled back). The events also show the
KnowledgeBaseVectorBucket creation succeeded — the s3vectors fix
from the previous PR worked.
2. Serialise scenario callers via a single repo-wide concurrency group
(scenario-ci-pool, cancel-in-progress=false). ISB enforces
maxLeasesPerUser=1 on ci-bot@ndx-try.local; concurrent dispatches
would all hit 409 except the first. PR fan-out on shared-infra
edits now queues runs one-at-a-time, taking longer wallclock but
actually completing each scenario instead of 15 hitting 409.
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISB caps 1 active lease per user; serialise scenario CI globally so fan-out doesn't 409. Plus add servicecatalog:* (council-chatbot uses AppRegistryApplication).