feat(ci-lease): S3 fallback for CDK-synth / SAM scenarios#403
Merged
Conversation
CDK-synth and SAM-style scenarios don't commit template.yaml (it's built by deploy-blueprints.yml and uploaded to the hub blueprints bucket). Without a fallback, scenario-ci.yml fails at 'Template not found' for those scenarios. The blueprints bucket already hosts every scenario's latest template at https://ndx-try-isb-blueprints-568672915267.s3.us-east-1.amazonaws.com/scenarios/<name>/template.yaml because it's the URL StackSets reference. Anonymous public GET works for that key path (no IAM auth needed in CI). ai-contact-centre is the immediate beneficiary: its source template has relative CodeUri paths that need sam-package to rewrite. The dist/ output (also uploaded to blueprints) has s3:// URIs and is deployable. Affected scenarios: ai-contact-centre, bops-planning, digital-planning-register, fixmystreet, localgov-drupal, localgov-ims, minute, paperless-ngx, planx, simply-readable. Hand-authored scenarios continue to use the committed template.yaml.
chrisns
had a problem deploying
to
smoke-test-deploy
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch template.yaml from the blueprints bucket when not committed locally. Enables CI for ai-contact-centre, bops-planning, fixmystreet, localgov-drupal, simply-readable, etc.