Use PythonImportRequirement #1669

arjunsinghy96 · 2017-04-25T18:57:16Z

Using PythonImportRequirement instead of PipRequirement for bears which
import directly into the bear.

Related to #1655

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

arjunsinghy96 · 2017-04-25T19:04:57Z

The commit 1 replaces PipRequirement with PythonImportRequirement where the bears import their dependencies.
For next commits:

Remove dependency import in bears
Use Class level variable REQUIREMENTS for imports.

arjunsinghy96 · 2017-04-25T20:45:58Z

I think we will need to amend Bears method check_prerequisites or add new method import_prerequisites to use PythonImportRequirement.

jayvdb

pep8 and autoflake look great. now you just need to do the same for the rest of the bears.
(We do not need extra hooks like import_prerequisites, there are other core enhancements which will mean these imports are done automatically for the bear, but that will be in 0.12)

jayvdb · 2017-04-26T00:54:12Z

bears/general/InvalidLinkBear.py

@@ -19,7 +20,7 @@
 class InvalidLinkBear(LocalBear):
    DEFAULT_TIMEOUT = 15
    LANGUAGES = {'All'}
-    REQUIREMENTS = {PipRequirement('requests', '2.12')}
+    REQUIREMENTS = {PythonImportRequirement('requests', '2.12')}


InvalidLinkBear doesnt need PythonImportRequirement

The only second party import is requests, which is also a dependency of coala.
So this bear doesnt have any extra dependencies.

jayvdb · 2017-04-26T00:59:44Z

bears/python/YapfBear.py

@@ -12,7 +13,11 @@
 class YapfBear(LocalBear):
    LANGUAGES = {'Python', 'Python 2', 'Python 3'}
    AUTHORS = {'The coala developers'}
-    REQUIREMENTS = {PipRequirement('yapf', '0.14.0')}
+    REQUIREMENTS = {PythonImportRequirement(
+                                        'yapf',


wow, ugly.
move PythonImportRequirement( down onto this line

arjunsinghy96 · 2017-04-26T21:15:04Z

PySafetyBearTest uses some voodoo which I am trying to understand. Not removed PySafetyBear imports currently.

jayvdb · 2017-04-27T00:21:25Z

bears/python/requirements/PySafetyBear.py

@@ -5,7 +5,8 @@
 from safety import safety


And this one? What was the problem?

It has to do something with lines like these in tests:

with mock.patch( 'bears.python.requirements.PySafetyBear.safety.check', return_value=[], ) as check:

when I remove from safety import safety in the Bear. All test fail.

gitmate-bot · 2017-05-05T01:07:22Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-12T17:04:22Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-05-12T22:48:42Z

bears/python/PyImportSortBear.py

@@ -46,11 +47,13 @@ def _seperate_imports(file):
        return import_stmts

    def _get_diff(self):
+        isort = list(self.__class__.REQUIREMENTS)[0]


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-05-12T22:48:43Z

bears/python/PyImportSortBear.py

@@ -12,7 +11,9 @@
 class PyImportSortBear(LocalBear):

    LANGUAGES = {'Python', 'Python 3', 'Python 2'}
-    REQUIREMENTS = {PipRequirement('isort', '4.2')}
+    REQUIREMENTS = {PythonImportRequirement('isort',
+                                            '4.2',


E128 continuation line under-indented for visual indent'

PycodestyleBear (E128), severity NORMAL, section autopep8.

gitmate-bot · 2017-05-12T22:48:44Z

bears/python/PyImportSortBear.py

@@ -46,11 +47,13 @@ def _seperate_imports(file):
        return import_stmts

    def _get_diff(self):
+        isort = list(self.__class__.REQUIREMENTS)[0]


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/python/PyImportSortBear.py +++ b/bears/python/PyImportSortBear.py @@ -71,7 +71,7 @@ return diff else: sort_imports = isort.SortImports(file_contents=''.join(self.file), - **self.isort_settings) + **self.isort_settings) new_file = tuple(sort_imports.output.splitlines(True)) if new_file != tuple(self.file):

gitmate-bot · 2017-05-12T22:48:45Z

bears/python/PyImportSortBear.py

@@ -12,7 +11,9 @@
 class PyImportSortBear(LocalBear):

    LANGUAGES = {'Python', 'Python 3', 'Python 2'}
-    REQUIREMENTS = {PipRequirement('isort', '4.2')}
+    REQUIREMENTS = {PythonImportRequirement('isort',
+                                            '4.2',


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/python/PyImportSortBear.py +++ b/bears/python/PyImportSortBear.py @@ -54,8 +54,8 @@ sorted_imps = [] for units in import_stmts: sort_imports = isort.SortImports(file_contents=''. - join([x[1] for x in units]), - **self.isort_settings) + join([x[1] for x in units]), + **self.isort_settings) sort_imports = sort_imports.output.splitlines(True) sorted_imps.append((units, sort_imports))

gitmate-bot · 2017-05-26T03:17:16Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

jayvdb · 2017-06-05T21:02:15Z

bears/natural_language/LanguageToolBear.py

@@ -53,8 +55,12 @@ def run(self,
        # language_check being there.
        from language_check import LanguageTool, correct

+        for requirement in list(self.__class__.REQUIREMENTS):


To make this a little less ugly, I have started https://gitlab.com/coala/package_manager/merge_requests/91 .
We would use it like REQUIREMENTS = AddressableRequirementSet([PythonImportRequirement(...), ...])
Let me know what you think. It isnt polished yet.

https://gitlab.com/coala/package_manager/merge_requests/91 has landed.
I'll get it released and available for you today.
But you can already experiment with it (e.g. by changing the versions manually).
I'd love to see your patch merged this weekend if possible, so I can finish #1000.

@jayvdb has this release happened yet?

alternatively we can use a list instead of a set for the requirement or make the pythonimportrequirement a class level constant, that'd be far simpler

coala core is using depman master, so this should now be ready to roll.

gitmate-bot · 2017-06-15T23:17:02Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

arjunsinghy96 · 2017-06-17T05:47:13Z

Oh no!! I messed up.

gitmate-bot · 2017-06-24T07:17:48Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-06-24T07:17:49Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-01T05:57:17Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-08T04:37:09Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-08T04:37:10Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2017-07-15T03:17:25Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

sils · 2017-07-20T09:12:47Z

bears/python/PEP8Bear.py

@@ -39,6 +37,8 @@ def run(self, filename, file,
        :param local_pep8_config: Set to true if autopep8 should use a config
                                  file as if run normally from this directory.
        """
+        autopep8 = list(self.__class__.REQUIREMENTS)[0]


dangerous, somebody might add something to the set and out of a sudden it might fail to work with some interpreters or completely nondeterministic

sils · 2017-07-20T09:14:18Z

good stuff, I really think we should have the import requirements at class level and put those into sets and use them directly, that's much more simpler and obvious than an AdressableRequirements class IMO

Using PythonImportRequirement instead of PipRequirement for these bears which import dependencies directly in bear: - GitCommitBear - LanguageToolBear - PEP8Bear - PEP8NotebookBear - PyCommentedCodeBear - PyImportSortBear - PyUnusedCodeBear - PyromaBear - PySafetyBear - RadonBear - reSTLintBear - RuboCopBear - SCSSLintBear - YAMLLintBear - YapfBear Related to coala#1655

Fixes some typos. Removes direct import in these bears: - PEP8Bear - PEP8NotebookBear - PyCommentedCodeBear - PyImportSortBear - PyUnusedCodeBear - PyromaBear - RadonBear - YapfBear - LanguageToolBear - reSTLintBear - RuboCopBear - SCSSLintBear - GitCommitBear - YAMLLintBear Closes coala#1655

gitmate-bot added process/pending review size/XXL review carefully! labels Apr 25, 2017

coala-bot added process/wip and removed process/pending review labels Apr 25, 2017

arjunsinghy96 force-pushed the pyIreq branch from 9d3bf37 to 7f06194 Compare April 25, 2017 20:32

gitmate-bot added process/pending review and removed process/wip labels Apr 25, 2017

jayvdb requested changes Apr 26, 2017

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Apr 26, 2017

arjunsinghy96 force-pushed the pyIreq branch from 7f06194 to dabb771 Compare April 26, 2017 21:08

gitmate-bot added process/pending review and removed process/wip labels Apr 26, 2017

arjunsinghy96 force-pushed the pyIreq branch from dabb771 to 7f06356 Compare April 26, 2017 21:33

jayvdb reviewed Apr 27, 2017

View reviewed changes

arjunsinghy96 force-pushed the pyIreq branch from 7f06356 to 0b73db9 Compare April 27, 2017 06:38

arjunsinghy96 force-pushed the pyIreq branch from 0b73db9 to 763a71d Compare May 12, 2017 22:47

gitmate-bot reviewed May 12, 2017

View reviewed changes

arjunsinghy96 force-pushed the pyIreq branch 2 times, most recently from 8a2fd89 to da223bf Compare May 18, 2017 08:41

arjunsinghy96 force-pushed the pyIreq branch from 12d3975 to c165026 Compare May 30, 2017 15:46

jayvdb reviewed Jun 5, 2017

View reviewed changes

coala-bot added process/wip and removed process/pending review labels Jun 17, 2017

arjunsinghy96 force-pushed the pyIreq branch from 0f75aed to 5aa6d0b Compare June 17, 2017 06:32

gitmate-bot added process/pending review and removed process/wip labels Jun 17, 2017

sils reviewed Jul 20, 2017

View reviewed changes

coala-bot added process/wip and removed process/pending review labels Jul 20, 2017

gitmate-bot added the status/STALE label Aug 31, 2017

arjunsinghy96 added 2 commits August 17, 2018 23:45

jayvdb force-pushed the pyIreq branch from 5aa6d0b to 43b65ed Compare August 17, 2018 16:52

gitmate-bot added process/pending review size/M difficulty/medium importance/high and removed process/wip size/XXL labels Aug 17, 2018

gitmate-bot assigned arjunsinghy96 Aug 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use PythonImportRequirement #1669

Use PythonImportRequirement #1669

arjunsinghy96 commented Apr 25, 2017 •

edited

Loading

arjunsinghy96 commented Apr 25, 2017 •

edited

Loading

arjunsinghy96 commented Apr 25, 2017

jayvdb left a comment

jayvdb Apr 26, 2017

jayvdb Apr 26, 2017

arjunsinghy96 commented Apr 26, 2017 •

edited

Loading

jayvdb Apr 27, 2017

arjunsinghy96 Apr 27, 2017 •

edited

Loading

gitmate-bot commented May 5, 2017

gitmate-bot commented May 12, 2017

gitmate-bot May 12, 2017

gitmate-bot May 12, 2017

gitmate-bot May 12, 2017

gitmate-bot May 12, 2017

gitmate-bot commented May 26, 2017

jayvdb Jun 5, 2017

jayvdb Jun 9, 2017

sils Jul 20, 2017

sils Jul 20, 2017

jayvdb Jul 20, 2018

gitmate-bot commented Jun 15, 2017

arjunsinghy96 commented Jun 17, 2017

gitmate-bot commented Jun 24, 2017

gitmate-bot commented Jun 24, 2017

gitmate-bot commented Jul 1, 2017

gitmate-bot commented Jul 8, 2017

gitmate-bot commented Jul 8, 2017

gitmate-bot commented Jul 15, 2017

sils Jul 20, 2017

sils commented Jul 20, 2017

Use PythonImportRequirement #1669

Are you sure you want to change the base?

Use PythonImportRequirement #1669

Conversation

arjunsinghy96 commented Apr 25, 2017 • edited Loading

Checklist

arjunsinghy96 commented Apr 25, 2017 • edited Loading

arjunsinghy96 commented Apr 25, 2017

jayvdb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arjunsinghy96 commented Apr 26, 2017 • edited Loading

Choose a reason for hiding this comment

arjunsinghy96 Apr 27, 2017 • edited Loading

Choose a reason for hiding this comment

gitmate-bot commented May 5, 2017

gitmate-bot commented May 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitmate-bot commented May 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gitmate-bot commented Jun 15, 2017

arjunsinghy96 commented Jun 17, 2017

gitmate-bot commented Jun 24, 2017

gitmate-bot commented Jun 24, 2017

gitmate-bot commented Jul 1, 2017

gitmate-bot commented Jul 8, 2017

gitmate-bot commented Jul 8, 2017

gitmate-bot commented Jul 15, 2017

Choose a reason for hiding this comment

sils commented Jul 20, 2017

arjunsinghy96 commented Apr 25, 2017 •

edited

Loading

arjunsinghy96 commented Apr 25, 2017 •

edited

Loading

arjunsinghy96 commented Apr 26, 2017 •

edited

Loading

arjunsinghy96 Apr 27, 2017 •

edited

Loading