CPPLintBear.py: Verify indentation and spaces

bears/c_languages/CPPLintBear.py

@@ -3,6 +3,12 @@
 from coalib.settings.Setting import typed_list
 
 
+def check_invalid_configuration(indent_size, use_spaces):
+    if indent_size != 2 or not use_spaces:
+        raise ValueError('CPPLint only supports an indentation size of 2, '
+                         'using only spaces.')
+
+
 @linter(executable='cpplint',
         use_stdout=False,
         use_stderr=True,
@@ -26,12 +32,17 @@ class CPPLintBear:
     def create_arguments(filename, file, config_file,
                          max_line_length: int=79,
                          cpplint_ignore: typed_list(str)=(),
-                         cpplint_include: typed_list(str)=()):
+                         cpplint_include: typed_list(str)=(),
+                         indent_size: int=2,
+                         use_spaces: bool=True):
         """
         :param max_line_length: Maximum number of characters for a line.
         :param cpplint_ignore:  List of checkers to ignore.
         :param cpplint_include: List of checkers to explicitly enable.
+        :param indent_size:     Only an indent size of 2 is permitted.
+        :param use_spaces:      Only the value `True` is permitted.
         """
+        check_invalid_configuration(indent_size, use_spaces)
         ignore = ','.join('-'+part.strip() for part in cpplint_ignore)
         include = ','.join('+'+part.strip() for part in cpplint_include)
         return ('--filter=' + ignore + ',' + include,

tests/c_languages/CPPLintBearTest.py

@@ -1,5 +1,12 @@
+from queue import Queue
+
 from bears.c_languages.CPPLintBear import CPPLintBear
-from coalib.testing.LocalBearTestHelper import verify_local_bear
+from coalib.testing.LocalBearTestHelper import (verify_local_bear,
+                                                LocalBearTestHelper)
+from coalib.testing.BearTestHelper import generate_skip_decorator
+from coalib.settings.Section import Section
+from coalib.settings.Setting import Setting
+
 
 test_file = """
 int main() {
@@ -26,3 +33,23 @@
     settings={'cpplint_ignore': 'legal',
               'max_line_length': '13'},
     tempfile_kwargs={'suffix': '.cpp'})
+
+
+@generate_skip_decorator(CPPLintBear)
+class CPPLintBearTest(LocalBearTestHelper):
+
+    CPP_VALUE_ERROR_RE = 'Bear returned None on execution'
+
+    def setUp(self):
+        self.section = Section('test section')
+        self.uut = CPPLintBear(self.section, Queue())
+
+    def test_config_failure_indent_size(self):
+        self.section.append(Setting('indent_size', 3))
+        with self.assertRaisesRegex(AssertionError, self.CPP_VALUE_ERROR_RE):
+            self.check_validity(self.uut, [], test_file)
+
+    def test_config_failure_use_spaces(self):
+        self.section.append(Setting('use_spaces', False))
+        with self.assertRaisesRegex(AssertionError, self.CPP_VALUE_ERROR_RE):
+            self.check_validity(self.uut, [], test_file)