URLBear: Use library to extract links #2822
Conversation
CLiu13
force-pushed
the
urlbear-extract-links
branch
2 times, most recently
from
103d5de to
b4acb90
Compare
CLiu13
force-pushed
the
urlbear-extract-links
branch
3 times, most recently
from
0c4d170 to
2268771
Compare
CLiu13
force-pushed
the
urlbear-extract-links
branch
from
2268771 to
27017f0
Compare
| def test_detect_example_url_result(self): | ||
| invalid_file = """ | ||
| http://example.com | ||
| """.splitlines() |
There was a problem hiding this comment.
Why is example.com an invalid url?
There was a problem hiding this comment.
The existing code for URLBear allows the user to input regex that specifies certain links to ignore, and the run() function of URLBear specifies example.com as a link to ignore, hence why I marked example.com as invalid.
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
gitmate-bot
force-pushed
the
urlbear-extract-links
branch
from
27017f0 to
970ff14
Compare
|
Automated rebase with GitMate.io was successful! 🎉 |
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
gitmate-bot
force-pushed
the
urlbear-extract-links
branch
from
970ff14 to
3d12720
Compare
|
Automated rebase with GitMate.io was successful! 🎉 |
|
Tests are failing. |
Failures are due to the use of URLExtract in Update: URLExtract 0.9 was released on 2/16 and can be found here. |
CLiu13
force-pushed
the
urlbear-extract-links
branch
from
3d12720 to
75f1da7
Compare
This replaces the use of regex for extracting links with the use of the URLExtract library. Closes coala#1342
CLiu13
force-pushed
the
urlbear-extract-links
branch
from
75f1da7 to
de2211a
Compare
This replaces the use of regex for extracting
links with the use of the URLExtract library.
Closes #1342
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!