Skip to content

perform more aggressive optimization #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 28, 2025
Merged

perform more aggressive optimization #1419

merged 16 commits into from
Mar 28, 2025

Conversation

stylewarning
Copy link
Member

@stylewarning stylewarning commented Mar 19, 2025 •
edited
Loading

This PR does a variety of things, but the most important are as follows:

  • During optimization, we propagate known dictionaries to their use sites.
  • During rewriting (inlining or specialization), we track if we do a rewrite, and if we do, we let the optimizer run again.
  • During inlining, we ensure the term being replaced and the replacement itself have unified types.
  • We make fixnum arithmetic optimized and unsafe.

Fix #1390

@stylewarning stylewarning force-pushed the propagate-like-crazy branch 14 times, most recently from cbc4d35 to e4efa8d Compare March 20, 2025 20:24
@stylewarning stylewarning force-pushed the propagate-like-crazy branch 5 times, most recently from 89e4295 to 4407e4b Compare March 24, 2025 16:03
@stylewarning stylewarning changed the title do several rounds of constant propagation and inlining allow several rounds of constant propagation and inlining Mar 24, 2025
@stylewarning stylewarning marked this pull request as ready for review March 24, 2025 16:07
YarinHeffes
YarinHeffes requested changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@YarinHeffes YarinHeffes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes in logic in range-decreasing.

@stylewarning stylewarning mentioned this pull request Mar 24, 2025
Closed
@stylewarning stylewarning force-pushed the propagate-like-crazy branch from 4407e4b to 348b4c0 Compare March 25, 2025 20:33
@stylewarning stylewarning marked this pull request as draft March 26, 2025 17:56
@stylewarning stylewarning force-pushed the propagate-like-crazy branch from 348b4c0 to 093f282 Compare March 26, 2025 17:59
@stylewarning stylewarning changed the title allow several rounds of constant propagation and inlining perform more aggressive optimization Mar 27, 2025
@stylewarning stylewarning force-pushed the propagate-like-crazy branch 3 times, most recently from 3d29911 to 79e5506 Compare March 27, 2025 04:05
@stylewarning
make UFix arithmetic processor-native
f0c293b 
This commit also fixes UFix underflow issues

- make RANGE-DECREASING handle unsigned types gracefully
- fix Seq's CST-SEARCH
- fix use of DECREMENT! in Brainfold example
@stylewarning
move inliner to its own file
3e68311
@stylewarning
move specializer to its own file
a9a0bb5
@stylewarning
add some docs and more precise types
c5da6ff
@stylewarning
move canonicalizer to its own file
24a6445
@stylewarning
add options to print when specialization/inlining occur
c4c67d6 
also return whether inlining occcurred as a second value
@stylewarning
expose DICTIONARY-NODE-P
4b9cd0b
@stylewarning
unify the term with its replacement in inlining
1a3b97b
@stylewarning
add :PRINT-REWRITES compiler option
e176753
@stylewarning
repeat optimization passes until no more rewriting occurs
a90f911
@stylewarning
propagate dictionaries downward for optimization
7333c9b
@stylewarning
remove let subexpression hack
78f9aa0
@stylewarning
add and make default a gentle inline heuristic
ed307d3
@stylewarning
limit number of optimization passes
da4deab
@stylewarning
eliminate nested COALTON use in num macros
34c49f3
@stylewarning stylewarning force-pushed the propagate-like-crazy branch from 79e5506 to 34c49f3 Compare March 27, 2025 04:29
@stylewarning stylewarning marked this pull request as ready for review March 27, 2025 04:31
@stylewarning stylewarning merged commit 1e0d061 into main Mar 28, 2025
25 checks passed
@stylewarning stylewarning deleted the propagate-like-crazy branch March 28, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarinHeffes YarinHeffes YarinHeffes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some specialized class instances are not inlined properly.
2 participants
@stylewarning @YarinHeffes